permit indexing of first-upload of dist with raw vstring version #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjbs
force-pushed
the
raw-vstring-version
branch
from
ab50def to
4291183
Compare
rjbs
force-pushed
the
raw-vstring-version
branch
3 times, most recently
from
0517ef1 to
6a16213
Compare
rjbs
force-pushed
the
raw-vstring-version
branch
2 times, most recently
from
921d828 to
0e9201c
Compare
rjbs
changed the title
Right now, this fails weirdly. See andk#365, which says: > If you're doing the first release of a package, and you set the version > string to an unquoted v-string, such as > > our $VERSION = v1.0.1; > > Then the uploader will get a message saying they don't have an indexing > permission on the package. > > Putting double quotes around the v-string will fix it, so we should at least > recognise the problem and tell the uploader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, this fails weirdly. See #365.
I predict easier to fix once we use PAUSE::Indexer::Context.