Skip to content

Commit

Permalink
XXX: tests for "our $VERSION = v8.67.53"
Browse files Browse the repository at this point in the history
Right now, this fails weirdly.  See #365, which says:

> If you're doing the first release of a package, and you set the version
> string to an unquoted v-string, such as
>
> our $VERSION = v1.0.1;
>
> Then the uploader will get a message saying they don't have an indexing
> permission on the package.
>
> Putting double quotes around the v-string will fix it, so we should at least
> recognise the problem and tell the uploader.
  • Loading branch information
rjbs committed May 12, 2024
1 parent eb329e8 commit 2442b1c
Showing 1 changed file with 30 additions and 0 deletions.
30 changes: 30 additions & 0 deletions t/mldistwatch-misc.t
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,36 @@ subtest "check various forms of version" => sub {
);
};

subtest "unquoted vstring version" => sub {
my $pause = PAUSE::TestPAUSE->init_new;
$pause->upload_author_fake(RJBS => {
name => 'Quod-Version',
version => '8.67.53',
packages => [
'Quod::Version' => {
version => 'v8.67.53',
layout => { version => 'our-literal' }
},
]
});

my $result = $pause->test_reindex;

$pause->file_not_updated_ok(
$result->tmpdir
->file(qw(cpan modules 02packages.details.txt.gz)),
"there were no things to update",
);

diag($_->{email}->as_string) for $result->deliveries;

$result->email_ok(
[
{ subject => 'PAUSE indexer report Quod-Version-8.67.53.tar.gz' },
],
);
};

subtest "version assigned to a blob as a ref" => sub {
my $pause = PAUSE::TestPAUSE->init_new;
$pause->upload_author_fake(LUNATIC => 'Globby-Version-1.234.tar.gz', {
Expand Down

0 comments on commit 2442b1c

Please sign in to comment.