Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AD719x support on DE10-Nano #1488

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Add AD719x support on DE10-Nano #1488

merged 2 commits into from
Nov 18, 2024
+397 −5

Conversation

StancaPop
Copy link
Contributor

PR Description

Add support for the AD719x on DE10-Nano, using the SPI Controller.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the code style guidelines
  • I have performed a self-review of changes
  • I have compiled all hdl projects and libraries affected by this PR
  • I have tested in hardware affected projects, at least on relevant boards
  • I have commented my code, at least hard-to-understand parts
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe files, Copyright etc)
  • I have not introduced new Warnings/Critical Warnings on compilation
  • I have added new hdl testbenches or updated existing ones

@sarpadi
Copy link
Contributor

sarpadi commented Oct 15, 2024

Missing MISO-GPIO connection
https://github.com/analogdevicesinc/hdl/blob/main/projects/ad719x_asdz/coraz7s/system_top.v#L101

sarpadi
sarpadi previously approved these changes Oct 29, 2024
View reviewed changes
IuliaCMoldovan
IuliaCMoldovan reviewed Oct 30, 2024
View reviewed changes
docs/projects/ad719x_asdz/index.rst Outdated
Comment on lines 19 to 21
- :adi:`EVAL-AD7195 <EVAL-AD7192>`
- :adi:`EVAL-AD7193 <EVAL-AD7193>`
- :adi:`EVAL-AD7195 <EVAL-AD7194>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a typo, as it would be 3 times AD7195.
Also, could you change lines 18-22 to be in this way?
:adi:`EVAL-AD719...`
It will render the same, just that it's simpler written in code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

projects/ad719x_asdz/README.md Outdated
@@ -1,13 +1,17 @@
# EVAL-AD719X-ASDZ HDL Project

This project supports EVAL-AD7190, EVAL-AD7193 and EVAL-AD7195.
This project supports EVAL-AD7190,EVAL-AD7192, EVAL-AD7193, EVAL-AD7194 and EVAL-AD7195.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This project supports EVAL-AD7190,EVAL-AD7192, EVAL-AD7193, EVAL-AD7194 and EVAL-AD7195.
This project supports EVAL-AD7190, EVAL-AD7192, EVAL-AD7193, EVAL-AD7194 and EVAL-AD7195.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

projects/ad719x_asdz/de10nano/Makefile Outdated
@@ -0,0 +1,16 @@
####################################################################################
## Copyright (c) 2018 - 2023 Analog Devices, Inc.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Copyright (c) 2018 - 2023 Analog Devices, Inc.
## Copyright (c) 2018 - 2024 Analog Devices, Inc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

projects/ad719x_asdz/de10nano/system_constr.sdc Outdated
@@ -0,0 +1,12 @@
###############################################################################
## Copyright (C) 2020-2023 Analog Devices, Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Copyright (C) 2020-2023 Analog Devices, Inc. All rights reserved.
## Copyright (C) 2024 Analog Devices, Inc. All rights reserved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

projects/ad719x_asdz/de10nano/system_project.tcl Outdated
@@ -0,0 +1,51 @@
###############################################################################
## Copyright (C) 2020-2023 Analog Devices, Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Copyright (C) 2020-2023 Analog Devices, Inc. All rights reserved.
## Copyright (C) 2024 Analog Devices, Inc. All rights reserved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

projects/ad719x_asdz/de10nano/system_project.tcl Outdated
Comment on lines 15 to 18
#
## down-rade Critical Warning reated to a asynchronous RAM in DMAC
#
## "mixed_port_feed_through_mode" parameter of RAM can not have value "old"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#
## down-rade Critical Warning reated to a asynchronous RAM in DMAC
#
## "mixed_port_feed_through_mode" parameter of RAM can not have value "old"
## downgrade Critical Warning related to an asynchronous RAM in DMAC
#
## "mixed_port_feed_through_mode" parameter of RAM cannot have value "old"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

projects/ad719x_asdz/de10nano/system_qsys.tcl Outdated
@@ -0,0 +1,14 @@
###############################################################################
## Copyright (C) 2020-2023 Analog Devices, Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## Copyright (C) 2020-2023 Analog Devices, Inc. All rights reserved.
## Copyright (C) 2024 Analog Devices, Inc. All rights reserved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

projects/ad719x_asdz/de10nano/system_top.v Outdated
@@ -0,0 +1,280 @@
// ***************************************************************************
// ***************************************************************************
// Copyright (C) 2020-2023 Analog Devices, Inc. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// Copyright (C) 2020-2023 Analog Devices, Inc. All rights reserved.
// Copyright (C) 2024 Analog Devices, Inc. All rights reserved.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@sarpadi
Copy link
Contributor

sarpadi commented Nov 13, 2024

Please squash the commits as needed

@StancaPop StancaPop merged commit a6c8d40 into main Nov 18, 2024
3 of 5 checks passed
@StancaPop StancaPop deleted the ad719x_de10nano branch November 18, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarpadi sarpadi sarpadi approved these changes

@gastmaier gastmaier Awaiting requested review from gastmaier gastmaier is a code owner

@LBFFilho LBFFilho Awaiting requested review from LBFFilho LBFFilho is a code owner

@cristianmihaipopa cristianmihaipopa Awaiting requested review from cristianmihaipopa

@IuliaCMoldovan IuliaCMoldovan Awaiting requested review from IuliaCMoldovan IuliaCMoldovan is a code owner

Assignees
No one assigned
Labels
doc new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StancaPop @sarpadi @IuliaCMoldovan