Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add frontend performance CI integration #4761

Open
wants to merge 54 commits into
base: develop
Choose a base branch
from
Open

Add frontend performance CI integration #4761

wants to merge 54 commits into from

Commits on Jul 20, 2020

  1. Add initial site population

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    42e8bf3 View commit details
    Browse the repository at this point in the history

  2. Commit initial version to try on GH

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    3582fab View commit details
    Browse the repository at this point in the history

  3. Avoid allocating pseudo-TTY within GHA

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    46b83c2 View commit details
    Browse the repository at this point in the history

  4. Add Composer & npm caching 

    No caching of Docker images yet, as that is not yet supported by GitHub Actions (see actions/cache#31).
    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    ed9dc34 View commit details
    Browse the repository at this point in the history

  5. Avoid Docker within Docker

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    6b2e72d View commit details
    Browse the repository at this point in the history

  6. Switch from localenv to manual setup in GHA 

    Although `docker-compose` _within_ a Docker container does seemingly work, any relative path mapping completely breaks, and I couldn't find a sane way of fixing it.

Hence the switch to manual construction within the Docker image, so that we don't face "Docker Inception" problems.
    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    ea1332e View commit details
    Browse the repository at this point in the history

  7. Manually start the MySQL server 

    See https://github.blog/changelog/2020-02-21-github-actions-breaking-change-ubuntu-virtual-environments-will-no-longer-start-the-mysql-service-automatically/
    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    380bd1f View commit details
    Browse the repository at this point in the history

  8. Use sudo for installing WP-CLI

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    0ea1a1a View commit details
    Browse the repository at this point in the history

  9. Use relative path as webroot

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    c1ff5e5 View commit details
    Browse the repository at this point in the history

  10. Try different way of starting MySQL service

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    26a0f1f View commit details
    Browse the repository at this point in the history

  11. Use sudo to install npm dependency globally

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    2e93e18 View commit details
    Browse the repository at this point in the history

  12. Add PWA plugin

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    25b9877 View commit details
    Browse the repository at this point in the history

  13. Switch site into transitional mode

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    beef80a View commit details
    Browse the repository at this point in the history

  14. Add separate release-zip workflow

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    ebd13ef View commit details
    Browse the repository at this point in the history

  15. Combine both jobs into single workflow file 

    As it turns out, you cannot "need" across workflow files.
    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    61849a7 View commit details
    Browse the repository at this point in the history

  16. Fix variable syntax

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    7463025 View commit details
    Browse the repository at this point in the history

  17. Extract logic to calculate SHA-8

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    a18b87b View commit details
    Browse the repository at this point in the history

  18. Directly use generated artifact filename

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    64d2fee View commit details
    Browse the repository at this point in the history

  19. Check into filesystem

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    5ee7bd2 View commit details
    Browse the repository at this point in the history

  20. Use correct filename for plugin installation

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    dda231a View commit details
    Browse the repository at this point in the history

  21. Add checkout to get lighthouse config

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    edcb980 View commit details
    Browse the repository at this point in the history

  22. Omit enforcing assertions

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    2ac35e7 View commit details
    Browse the repository at this point in the history

  23. Use branch name instead of version string

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    af64586 View commit details
    Browse the repository at this point in the history

  24. Skip assertions

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    1190f06 View commit details
    Browse the repository at this point in the history

  25. Revert changes to dev env, as they are not used anymore

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    960ea4f View commit details
    Browse the repository at this point in the history

  26. Add lhci upload credentials

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    a5742db View commit details
    Browse the repository at this point in the history

  27. Switch cache back to v1

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    3f42ae2 View commit details
    Browse the repository at this point in the history

  28. Remove indentation from multi-line commands$

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    b22fd8f View commit details
    Browse the repository at this point in the history

  29. Default to multi-line run syntax

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    9780c22 View commit details
    Browse the repository at this point in the history

  30. Add target to lhci upload

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    014b254 View commit details
    Browse the repository at this point in the history

  31. Remove config prefix keys for console arguments

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    1cfe409 View commit details
    Browse the repository at this point in the history

  32. Add missing backslash

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    c818bdf View commit details
    Browse the repository at this point in the history

  33. Install and activate the Yoast SEO plugin to fix SEO issues

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    360d452 View commit details
    Browse the repository at this point in the history

  34. Fix typo in plugin name

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    0664996 View commit details
    Browse the repository at this point in the history

  35. Create basic robots.txt file

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    ae64db4 View commit details
    Browse the repository at this point in the history

  36. Add URL Toggles plugin and measure variations

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    2350f6e View commit details
    Browse the repository at this point in the history

  37. Fix PHPCS issues with URL Toggles plugin

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    96ef2b9 View commit details
    Browse the repository at this point in the history

  38. Remove Yoast again and add simple meta description MU plugin

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    bee1097 View commit details
    Browse the repository at this point in the history

  39. Fix PHPCS issues with meta description plugin

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    b8b4fbc View commit details
    Browse the repository at this point in the history

  40. Add job name for lighthouse

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    0529f51 View commit details
    Browse the repository at this point in the history

  41. Adapt path to artifacts

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    593291e View commit details
    Browse the repository at this point in the history

  42. Shorten workflow name to avoid truncation in UI

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    f7b3187 View commit details
    Browse the repository at this point in the history

  43. Fix path name

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    0136ab4 View commit details
    Browse the repository at this point in the history

  44. Adapt lighthouse task to add reference site import

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    309c7a1 View commit details
    Browse the repository at this point in the history

  45. Remove duplicate comment

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    a3b620f View commit details
    Browse the repository at this point in the history

  46. Add autoload dump

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    10809a5 View commit details
    Browse the repository at this point in the history

  47. Fully install Composer dependencies

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    2a32d2c View commit details
    Browse the repository at this point in the history

  48. Update Composer configuration

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    cb77df9 View commit details
    Browse the repository at this point in the history

  49. Load reference site logic outside of active plugin

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    4bbb0b4 View commit details
    Browse the repository at this point in the history

  50. Fix ZIP requirement

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    0a448eb View commit details
    Browse the repository at this point in the history

  51. Add WordPress Importer plugin as is required for reference site

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    b0d0ab0 View commit details
    Browse the repository at this point in the history

  52. Fix importer plugin path

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    ea9ba86 View commit details
    Browse the repository at this point in the history

  53. Add WebP support

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    dc171a6 View commit details
    Browse the repository at this point in the history

  54. Remove WebP plugin again

    @schlessera
    schlessera committed Jul 20, 2020
    Configuration menu
    Copy the full SHA
    883c28c View commit details
    Browse the repository at this point in the history