Add frontend performance CI integration #4761
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schlessera
added
the
Infrastructure
schlessera
force-pushed
the
add/4569-frontend-performance-ci
branch
2 times, most recently
from
25fbaf0
to
1f6db44
Compare
schlessera
added a commit
that referenced
this pull request
May 25, 2020
This file was initially built within #4761, but moved into a separate PR for faster merging.
7 tasks
|
The Lighthouse data collection works and can be seen here: http://lhci.amp-wp.org/app/projects/amp-for-wordpress/dashboard Current state of a Twentytwenty homepage: |
|
The Lighthouse CI server does not provide a way for making comparisons across URLs, so it's unnecessarily difficult to see the impact of the Optimizer or SSR right now. I've opened an issue on the server repo: GoogleChrome/lighthouse-ci#338 |
|
Plugin builds for 883c28c are ready 🛎️!
|
No caching of Docker images yet, as that is not yet supported by GitHub Actions (see actions/cache#31).
Although `docker-compose` _within_ a Docker container does seemingly work, any relative path mapping completely breaks, and I couldn't find a sane way of fixing it. Hence the switch to manual construction within the Docker image, so that we don't face "Docker Inception" problems.
As it turns out, you cannot "need" across workflow files.
schlessera
force-pushed
the
add/4569-frontend-performance-ci
branch
from
7b2a8c8
to
309c7a1
Compare
|
^^^ |
schlessera
changed the base branch from
develop
to
add/4571-build-reference-site
schlessera
added
WS:Perf
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a GitHub Actions workflow called "Build, Test & Measure" with currently two separate jobs:
release-zipThis job checks out the source, fetches Composer and npm dependencies and does a complete build.
It then uploads the produced ZIP file as an artifact with the filename having the form
amp-{branch}-{short-sha}.zip.Todo:
lighthouse(depends on
release-zip)This job sets up a complete WordPress installation, installs both the AMP and the PWA plugins and then runs the Lighthouse CI over a set of URLs to audit the performance.
The assertions are currently disabled, because we're not passing the default recommendation yet, and haven't discussed what our hard targets are.
Todo:
Fixes #4569
Checklist