Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload profiler data to remote save folder #338

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Upload profiler data to remote save folder #338

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fd8356e
upload profiler data
epwalsh Oct 18, 2023
252731b
logging
epwalsh Oct 18, 2023
4c647bb
skip uploading stacks
epwalsh Oct 31, 2023
074acd5
no stacks
epwalsh Oct 31, 2023
7bff312
Merge branch 'main' into epwalsh/upload-profiler-data
epwalsh Oct 31, 2023
6525946
fix import
epwalsh Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions olmo/train.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@
move_to_device,
peak_gpu_memory,
syncronize_flag,
upload,
)

__all__ = ["SpeedMonitor", "LRMonitor", "Trainer"]
Expand Down Expand Up @@ -737,9 +738,13 @@ def on_trace_ready(p):
output = p.key_averages().table(sort_by="self_cpu_time_total", row_limit=32)
log.info(f"Profile by total CPU time at step {p.step_num}:\n{output}")

p.export_chrome_trace(str(profiler_output_dir / f"{p.step_num}.chrome_trace.json.gz"))
p.export_stacks(str(profiler_output_dir / f"{p.step_num}.gpu.stacks"), "self_cuda_time_total")
p.export_stacks(str(profiler_output_dir / f"{p.step_num}.cpu.stacks"), "self_cpu_time_total")
p.export_chrome_trace(
str(trace_path := (profiler_output_dir / f"{p.step_num}.chrome_trace.json.gz"))
)
if self.cfg.remote_save_folder is not None:
upload_folder = f"{self.cfg.remote_save_folder.rstrip('/')}/profiler"
log.info(f"Tracing complete, uploading results to '{upload_folder}'...")
upload(trace_path, f"{upload_folder}/{trace_path.name}")

from torch.profiler import ProfilerActivity

Expand Down
Loading