Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload profiler data to remote save folder #338

Merged
merged 6 commits into from
Oct 31, 2023
Merged

Upload profiler data to remote save folder #338

merged 6 commits into from
Oct 31, 2023

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Oct 25, 2023

  • upload profiler data
  • logging

@dirkgr
Copy link
Member

dirkgr commented Oct 31, 2023

Oh, I've been meaning to do this! You can get rid of the stacks stuff though. Those files end up always empty.

@epwalsh epwalsh requested a review from dirkgr October 31, 2023 18:09
dirkgr
dirkgr requested changes Oct 31, 2023
View reviewed changes
Copy link
Member

@dirkgr dirkgr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get rid of the entire stacks thing altogether. We don't even need to write those files.

@epwalsh epwalsh requested a review from dirkgr October 31, 2023 20:44
@epwalsh epwalsh merged commit 1099942 into main Oct 31, 2023
10 checks passed
@epwalsh epwalsh deleted the epwalsh/upload-profiler-data branch October 31, 2023 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dirkgr dirkgr dirkgr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epwalsh @dirkgr