Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated Workflow Checks for Data and Models #566

Merged
merged 10 commits into from
Jul 25, 2023

Conversation

Tonks684
Copy link
Contributor

@Tonks684 Tonks684 commented May 25, 2023

Fix #479

@acocac acocac changed the title Update catalog_entry_form.js Automated Workflow Checks for Data and Models May 25, 2023
@acocac acocac marked this pull request as draft May 26, 2023 15:08
@Tonks684
Copy link
Contributor Author

Tonks684 commented Jun 6, 2023

I have created automated_dataset_checks.py file in the dev folder. As discussed with @ots22 and @acocac the file iterates through the dataset catalog using the load_dataset function and logs any datsets that fail to load. At the moment 2/11 fail and they are stardist and cell-cycle-scivision.

Cell Cycle Scivision
Error message: 404 File Not Found
image
Reason for error: Examining the load_dataset function it fails because the yaml file is '.yaml' and the path is hard coded to be '/scivision/data.yml'
Proposed solution: Remove hard coded '.yml' and allow for 'y
ml'

Stardist
Error message: 404 File Not Found
image
Reason for error: Examining the load_dataset function it fails because the url path is to a zip file.
Proposed solutions: Adjust the load_dataset function to work with zip files or we could create a .yml template for data uploads where the images are contained in a zip file.

@ots22
Copy link
Member

ots22 commented Jun 7, 2023

Hi Sam, this seems very useful.

It looks like there are some additional commits to push (I can just see a single commit with a small change)?

If fixing the broken entries seems beyond the scope of this PR, definitely consider raising issues and we can address them separately.

@ots22
Copy link
Member

ots22 commented Jul 13, 2023

@Tonks684 @acocac would you be happy with merging this, so the script is on main? Then making separate PRs for models/automation?

Are you happy too with the renaming (introduced above)?

@Tonks684 Tonks684 marked this pull request as ready for review July 25, 2023 11:04
@Tonks684 Tonks684 merged commit 43ae1e8 into main Jul 25, 2023
@ots22 ots22 deleted the automatic-scivision-checks branch August 9, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Regular automatic scivision checks
3 participants