Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: test_load_dataset_from_stac_plugin #578

Closed
ots22 opened this issue Jun 22, 2023 · 6 comments · Fixed by #579
Closed

Failing test: test_load_dataset_from_stac_plugin #578

ots22 opened this issue Jun 22, 2023 · 6 comments · Fixed by #579
Labels
bug Something isn't working

Comments

@ots22
Copy link
Member

ots22 commented Jun 22, 2023

$ python -m pytest -k test_load_dataset_from_stac_plugin
FAILED tests/test_reader.py::test_load_dataset_from_stac_plugin - pystac_client.warnings.DoesNotConformTo: Server does not conform to ITEM_SEARCH, There is not fallback option available for search.

Failure suggests something upstream has changed/broken

@ots22 ots22 added the bug Something isn't working label Jun 22, 2023
@IFenton
Copy link
Contributor

IFenton commented Jun 22, 2023

@ots22 Would you like me to look in to this?

@ots22
Copy link
Member Author

ots22 commented Jun 22, 2023

Hi @IFenton - some progress so far:

Directly using the pystac_client library

>>> from pystac_client import Client
>>> catalog = Client.open("https://earth-search.aws.element84.com/v0")
>>> catalog.search()

fails with DoseNotConformTo exception.

The 'v1' API does not have this issue (see https://www.element84.com/earth-search/examples/):

>>> catalog = Client.open("https://earth-search.aws.element84.com/v1")
>>> query = catalog.search(collections=["sentinel-s2-l2a-cogs"], datetime=["2021-09-16"], bbox=(113.0,-26.0,114.0,-25.0), limit=10)
>>> list(query.items())

The resulting query is empty, however - I haven't looked at why that could be

@ots22
Copy link
Member Author

ots22 commented Jun 22, 2023

Suggestions:

@ots22
Copy link
Member Author

ots22 commented Jun 22, 2023

...make sure this is included in the catalog...

It is in the data catalogue already, as sentinel2_stac

@IFenton
Copy link
Contributor

IFenton commented Jun 22, 2023

The 'v1' API does not have this issue (see https://www.element84.com/earth-search/examples/):

catalog = Client.open("https://earth-search.aws.element84.com/v1")
query = catalog.search(collections=["sentinel-s2-l2a-cogs"], datetime=["2021-09-16"], bbox=(113.0,-26.0,114.0,-25.0), limit=10)
list(query.items())

The resulting query is empty, however - I haven't looked at why that could be

It seems to be because v1 doesn't have the relevant collection ('sentinel-s2-l2a-cogs')

@ots22
Copy link
Member Author

ots22 commented Jun 22, 2023

Ah, that's why then!

The above PR removes the test since it isn't failing in a way that gives useful information - do you think this is the right approach @IFenton? (Please could you 'review'?)

The issue really belongs to https://github.com/alan-turing-institute/scivision_sentinel2_stac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants