-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logging for container instances #2295
Conversation
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and this is definitely worth merging on its own. However, is it possible to get the container logs into the workspace too? They're more interesting than logging when containers turn on and off (which is unlikely to be very useful to many people).
Yes, they are there too 🚀 |
@JimMadge: does this include logs from terminated containers (which are otherwise inaccessible)? |
Yes, as long as the workspace gets the log it is kept there. |
✅ Checklist
Enable foobar integration
rather than515 foobar
).develop
.🚦 Depends on
🌂 Related issues
Contributes to #1922
🔬 Tests
Tested in a new deployment, screenshots below.