Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable monitoring agent to transmit to log analytics workspace #2279

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

craddm
Copy link
Contributor

@craddm craddm commented Nov 6, 2024

✅ Checklist

  • You have given your pull request a meaningful title (e.g. Enable foobar integration rather than 515 foobar).
  • You are targeting the appropriate branch. If you're not certain which one this is, it should be develop.
  • Your branch is up-to-date with the target branch (it probably was when you started, but it may have changed since then).

🚦 Depends on

⤴️ Summary

For Azure Monitoring Agent to be able to connect to a log analytics workspace, the VM it is on must have a Managed Identity.

This PR gives each VM a system-assigned managed identity, allowing the transmission of logs and metrics from the VM to the log analytics workspace.

An alternative would be to create a single managed identity to be shared across all VMs as a user-assigned managed identity rather than a system-assigned one.

🌂 Related issues

Closes #1931

🔬 Tests

Deployed a new SRE and observed that the logs are appropriately populated in the log analytics workspace.

Copy link

github-actions bot commented Nov 6, 2024

Coverage report

This PR does not seem to contain any modification to coverable code.

@jemrobinson
Copy link
Member

This is the correct fix. The identity of each VM should be distinct and system-managed identities are easier to manage than user-managed ones.

@craddm craddm changed the title [WIP] Enable monitoring agent to transmit to log analytics workspace Enable monitoring agent to transmit to log analytics workspace Nov 7, 2024
@craddm craddm marked this pull request as ready for review November 7, 2024 11:28
@craddm craddm requested a review from a team as a code owner November 7, 2024 11:28
Copy link
Member

@jemrobinson jemrobinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@craddm craddm merged commit fdbb029 into alan-turing-institute:develop Nov 7, 2024
11 checks passed
@craddm craddm deleted the managed-id-workspace branch November 13, 2024 14:15
@JimMadge JimMadge mentioned this pull request Nov 20, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VMs not connecting to Log Analytics Workspace
2 participants