Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-1.1): fix(controller): do not normalize urls when searching for image creds #3114

Merged
merged 1 commit into from
Dec 10, 2024

fix(controller): do not normalize urls when searching for image creds…

135a489
Select commit
Loading
Failed to load commit list.
Merged

chore(backport release-1.1): fix(controller): do not normalize urls when searching for image creds #3114

fix(controller): do not normalize urls when searching for image creds…
135a489
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 10, 2024 in 1s

51.15% (-0.01%) compared to d9932c7, passed because coverage increased by 0% when compared to adjusted base (51.14%)

View this Pull Request on Codecov

51.15% (-0.01%) compared to d9932c7, passed because coverage increased by 0% when compared to adjusted base (51.14%)

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.15%. Comparing base (d9932c7) to head (135a489).

Files with missing lines Patch % Lines
internal/credentials/kubernetes/database.go 66.66% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.1    #3114      +/-   ##
===============================================
- Coverage        51.15%   51.15%   -0.01%     
===============================================
  Files              283      283              
  Lines            25462    25471       +9     
===============================================
+ Hits             13026    13030       +4     
- Misses           11743    11748       +5     
  Partials           693      693              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.