Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(backport release-1.1): fix(controller): do not normalize urls when searching for image creds #3114

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

akuitybot
Copy link

Automated backport to release-1.1, triggered by a label in #3110.

Copy link

netlify bot commented Dec 10, 2024

Deploy Preview for docs-kargo-io ready!

Name Link
🔨 Latest commit 135a489
🔍 Latest deploy log https://app.netlify.com/sites/docs-kargo-io/deploys/6758468538ff430008049cfb
😎 Deploy Preview https://deploy-preview-3114.docs.kargo.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.15%. Comparing base (d9932c7) to head (135a489).
Report is 1 commits behind head on release-1.1.

Files with missing lines Patch % Lines
internal/credentials/kubernetes/database.go 66.66% 5 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.1    #3114      +/-   ##
===============================================
- Coverage        51.15%   51.15%   -0.01%     
===============================================
  Files              283      283              
  Lines            25462    25471       +9     
===============================================
+ Hits             13026    13030       +4     
- Misses           11743    11748       +5     
  Partials           693      693              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@krancour krancour merged commit 31d32d7 into release-1.1 Dec 10, 2024
23 checks passed
@krancour krancour deleted the backport-3110-to-release-1.1 branch December 10, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants