Fix entry update logic

[aivanovski]

Summary by CodeRabbit

• New Features

  • Improved management of note history and attachments for enhanced data integrity.
  • Unique filtering of attachments based on hash values to prevent duplicates.

• Bug Fixes

  • Refined error handling for insert and update operations, ensuring clearer communication of success or failure.

• Refactor

  • Streamlined database operations for adding or removing entries, enhancing robustness and accuracy.

[coderabbitai]

Walkthrough

The changes in this pull request primarily involve the KotpassNoteDao class, focusing on enhancing note history management and attachment handling. Key modifications include the adjustment of how historical entries are recorded, improvements in filtering attachments for uniqueness, refined error handling during database operations, and a more robust approach to managing database state during insertions and updates.

Changes

File	Change Summary
app/src/main/kotlin/com/ivanovsky/passnotes/data/repository/keepass/kotpass/KotpassNoteDao.kt	- Modified prepareEntryHistory to add old entries with an empty history list. - Updated prepareAttachmentsDiff to filter old attachments for uniqueness and combine new attachments appropriately. - Refined error handling in insert and update methods for clearer success/failure checks. - Streamlined database operations for adding/removing entries from groups, enhancing robustness.

Possibly related PRs

• Fix crash when adding attachment to existing entry #280: The changes in this PR also modify the prepareAttachmentsDiff method in the KotpassNoteDao class, focusing on how attachments are handled, which directly relates to the attachment management improvements in the main PR.

Poem

🐰 In the land of notes and tales,
Attachments dance on gentle trails.
With history clear and errors few,
The Kotpass keeps its secrets true.
Hopping high, we celebrate,
A rabbit's joy in every state! 🌟

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 0a8f5f4 and fe9fd38.

📒 Files selected for processing (1)

• app/src/main/kotlin/com/ivanovsky/passnotes/data/repository/keepass/kotpass/KotpassNoteDao.kt (2 hunks)

🧰 Additional context used

🔇 Additional comments (4)

app/src/main/kotlin/com/ivanovsky/passnotes/data/repository/keepass/kotpass/KotpassNoteDao.kt (4)

273-273: Prevent nested histories by clearing the history field

By adding oldEntry.copy(history = emptyList()) to the history list, the change ensures that when the old entry is added to the history, it does not include its own history, preventing nested histories.

---

316-318: Ensure uniqueness of old attachments by deduplicating based on hash

Applying .distinctBy { reference -> reference.hash } ensures that oldAttachments only contains unique attachments, avoiding duplicates that could lead to redundant data or inconsistencies.

---

321-324: Collect and convert binaries from new history entries

The code correctly gathers binaries from newHistory entries and converts them to attachments, ensuring that attachments from history are included in the comparison.

---

325-326: Combine new attachments and remove duplicates by hash

By combining newHistoryAttachments with newNote.attachments and using .distinctBy { attachment -> attachment.hash }, the code effectively consolidates all new attachments while eliminating any duplicates based on their hash values.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.