Merge pull request #282 from aivanovski/feature/279-issue-with-keepas…

…sdx-if-i-open-database-via-keepassvault Fix entry update logic
aivanovski · Oct 19, 2024 · 4709f5e · 4709f5e
2 parents 0a8f5f4 + fe9fd38
commit 4709f5e
Showing 1 changed file with 8 additions and 10 deletions.
diff --git a/...src/main/kotlin/com/ivanovsky/passnotes/data/repository/keepass/kotpass/KotpassNoteDao.kt b/...src/main/kotlin/com/ivanovsky/passnotes/data/repository/keepass/kotpass/KotpassNoteDao.kt
@@ -270,7 +270,7 @@ class KotpassNoteDao(
                 .drop(excessiveHistoryItems)
                 .toMutableList()
                 .apply {
-                    add(oldEntry)
+                    add(oldEntry.copy(history = emptyList()))
                 }
         } else {
             emptyList()
@@ -313,19 +313,17 @@ class KotpassNoteDao(
                     addAll(historyEntry.binaries)
                 }
             }
+            .distinctBy { reference -> reference.hash }
             .toAttachments(
                 allBinaries = oldBinariesMap
             )
 
-        val newAttachments = mutableListOf<Attachment>()
-            .apply {
-                addAll(
-                    newHistory
-                        .flatMap { entry -> entry.binaries }
-                        .toAttachments(allBinaries = oldBinariesMap)
-                )
-                addAll(newNote.attachments)
-            }
+        val newHistoryAttachments = newHistory
+            .flatMap { entry -> entry.binaries }
+            .toAttachments(allBinaries = oldBinariesMap)
+
+        val newAttachments = (newHistoryAttachments + newNote.attachments)
+            .distinctBy { attachment -> attachment.hash }
 
         val attachmentsDiff = differ.getAttachmentsDiff(oldAttachments, newAttachments)
         return if (attachmentsDiff.isNotEmpty()) {