Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message passing with more information #291

Draft
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 1, 2024

  • Simplipy _create_state_instance so it only need to do real object creation.
  • Killed state message is a message type
  • Make message not global variable and able to attach with more information.
  • pause/play/state all using build method to build the message.

@unkcpz unkcpz marked this pull request as draft December 1, 2024 11:30
@unkcpz
Copy link
Member Author

unkcpz commented Dec 1, 2024

A lot of single quotes to double quotes changes came from my IDE linter, should be reduced if #289 get merged and this PR will contains much less line changes.

@unkcpz unkcpz force-pushed the Message-passing-with-more-information branch from ad17069 to d7078fc Compare December 1, 2024 13:46
@unkcpz unkcpz force-pushed the Message-passing-with-more-information branch from ed2a043 to 96c5842 Compare December 1, 2024 21:12
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 86.85714% with 23 lines in your changes missing coverage. Please review.

Project coverage is 90.77%. Comparing base (14b7c1a) to head (96c5842).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/plumpy/processes.py 78.95% 8 Missing ⚠️
src/plumpy/event_helper.py 0.00% 2 Missing ⚠️
src/plumpy/ports.py 85.72% 2 Missing ⚠️
src/plumpy/process_comms.py 90.00% 2 Missing ⚠️
src/plumpy/process_states.py 89.48% 2 Missing ⚠️
src/plumpy/base/state_machine.py 96.30% 1 Missing ⚠️
src/plumpy/communications.py 75.00% 1 Missing ⚠️
src/plumpy/events.py 75.00% 1 Missing ⚠️
src/plumpy/persistence.py 85.72% 1 Missing ⚠️
src/plumpy/process_listener.py 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   90.77%   90.77%           
=======================================
  Files          22       22           
  Lines        2990     2990           
=======================================
  Hits         2714     2714           
  Misses        276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz force-pushed the Message-passing-with-more-information branch from 43e1520 to 737adf3 Compare December 1, 2024 23:56
@unkcpz unkcpz added the pr/blocked PR is blocked by another PR that should be merged first label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr/blocked PR is blocked by another PR that should be merged first
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant