Type extension aiopika workaround

[unkcpz]

Based on #289

[codecov]

Codecov Report

Attention: Patch coverage is 86.48649% with 15 lines in your changes missing coverage. Please review.

Project coverage is 90.78%. Comparing base (14b7c1a) to head (ef7b10b).
Report is 3 commits behind head on master.

Files with missing lines	Patch %	Lines
src/plumpy/event_helper.py	0.00%	2 Missing ⚠️
src/plumpy/ports.py	85.72%	2 Missing ⚠️
src/plumpy/process_states.py	75.00%	2 Missing ⚠️
src/plumpy/processes.py	83.34%	2 Missing ⚠️
src/plumpy/communications.py	75.00%	1 Missing ⚠️
src/plumpy/events.py	75.00%	1 Missing ⚠️
src/plumpy/persistence.py	85.72%	1 Missing ⚠️
src/plumpy/process_comms.py	66.67%	1 Missing ⚠️
src/plumpy/process_listener.py	0.00%	1 Missing ⚠️
src/plumpy/process_spec.py	50.00%	1 Missing ⚠️
... and 1 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #292      +/-   ##
==========================================
+ Coverage   90.77%   90.78%   +0.01%     
==========================================
  Files          22       22              
  Lines        2990     2980      -10     
==========================================
- Hits         2714     2705       -9     
+ Misses        276      275       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sphuber]

What is the scope of this PR @unkcpz You referenced it in #289 saying that this should just fix the typing_extensions import error. But there seem to be a lot of changes here.

[unkcpz]

After #289 there is only the last commit will fix typing_extensions error. That one should go first.

[sphuber]

After #289 there is only the last commit will fix typing_extensions error. That one should go first.

I don't understand. Do you mean in this PR you just mean to merge ef7b10b ? If so, could you please update the branch to just include that commit?

[unkcpz]

Do you mean in this PR you just mean to merge ef7b10b ?

Yes.

If so, could you please update the branch to just include that commit?

But the PR was from the branch of my fork.
Sorry if it is confusing.

[sphuber]

Yeah, but now this PR would change over a 1000 lines. Surely that is not the intention?

[unkcpz]

Yes, I was waiting for the merge of #289 :) I should put "blocked" tag for this one.

[sphuber]

But there the CI is failing because of the fix you put here? Why not just put just that fix in this PR, we merge that, and then you update the other PR and tests will pass. Since the fix doesn't touch any of the other changes, there should be no conflicts whatsoever. In fact, you would just do on the branch of this PR

git reset --hard origin/master
git cherry-pick ef7b10b3b4226056b59be4c4b9da8e8d7b399fc5

Now you just have the commit with the fix

[unkcpz]

I see. Not sure what I did I tried with cherry-pick but it closes the PR. I'll open a new one with the change.