Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plumpy.ProcessListener made persistent support/0.21.x #277

Merged
merged 4 commits into from
Nov 10, 2023
Merged

plumpy.ProcessListener made persistent support/0.21.x #277

merged 4 commits into from
Nov 10, 2023

Commits on Nov 10, 2023

  1. plumpy.ProcessListener made persistent 

    solves aiidateam#273

We implement the persistence of ProcessListener by deriving the class
ProcessListener and EventHelper from persistence.Savable.
The class EventHelper is moved to a new file because of a circular
import with utils and persistence

Fixing the test

There was a circular reference issue in the test listener that was
storing a reference to the process inside it, making its serialization
impossible. To fix the tests an ugly hack was used: storing the
reference to the process outside the class in a global dict using id as
keys. Some more ugly hacks are needed to check correctly the equality of
two processes. We must ignore the fact that the instances if the
listener are different.

We call del on dict items of the ProcessListener's global implemented in the test suite
to clean the golbal variables

addressed issues in aiidateam#274
    @rikigigi
    rikigigi committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    63ab5ec View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @sphuber
    sphuber authored Nov 10, 2023
    Configuration menu
    Copy the full SHA
    79df6ad View commit details
    Browse the repository at this point in the history

  3. Update src/plumpy/event_helper.py

    @sphuber
    sphuber authored Nov 10, 2023
    Configuration menu
    Copy the full SHA
    6eb00d9 View commit details
    Browse the repository at this point in the history

  4. Update src/plumpy/event_helper.py

    @sphuber
    sphuber authored Nov 10, 2023
    Configuration menu
    Copy the full SHA
    303685a View commit details
    Browse the repository at this point in the history