plumpy.ProcessListener made persistent support/0.21.x #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solves aiidateam#273 We implement the persistence of ProcessListener by deriving the class ProcessListener and EventHelper from persistence.Savable. The class EventHelper is moved to a new file because of a circular import with utils and persistence Fixing the test There was a circular reference issue in the test listener that was storing a reference to the process inside it, making its serialization impossible. To fix the tests an ugly hack was used: storing the reference to the process outside the class in a global dict using id as keys. Some more ugly hacks are needed to check correctly the equality of two processes. We must ignore the fact that the instances if the listener are different. We call del on dict items of the ProcessListener's global implemented in the test suite to clean the golbal variables addressed issues in aiidateam#274
rikigigi
changed the title
sphuber
requested changes
Nov 10, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## support/0.21.x #277 +/- ##
==================================================
- Coverage 90.82% 90.72% -0.09%
==================================================
Files 21 22 +1
Lines 2973 2995 +22
==================================================
+ Hits 2700 2717 +17
- Misses 273 278 +5
☔ View full report in Codecov by Sentry. |
sphuber
requested changes
Nov 10, 2023
sphuber
reviewed
Nov 10, 2023
sphuber
pushed a commit
that referenced
this pull request
Nov 13, 2023
The `ProcessListener` is made persistable by deriving it, as well as the `EventHelper` class from `persistence.Savable`. The class `EventHelper` is moved to a new file because of a circular import that would result between the `utils` and `persistence` modules. There was a circular reference issue in the test listener that was storing a reference to the process inside it, making its serialization impossible. To fix the tests an ugly hack was used: storing the reference to the process outside the class in a global dict using id as keys. Some more ugly hacks were needed to correctly check the equality of two processes. Instances having different listeners should be ignored. Cherry-pick: 98a375f
sphuber
pushed a commit
that referenced
this pull request
Nov 13, 2023
The `ProcessListener` is made persistable by deriving it, as well as the `EventHelper` class from `persistence.Savable`. The class `EventHelper` is moved to a new file because of a circular import that would result between the `utils` and `persistence` modules. There was a circular reference issue in the test listener that was storing a reference to the process inside it, making its serialization impossible. To fix the tests an ugly hack was used: storing the reference to the process outside the class in a global dict using id as keys. Some more ugly hacks were needed to correctly check the equality of two processes. Instances having different listeners should be ignored. Cherry-pick: 98a375f
sphuber
pushed a commit
that referenced
this pull request
Nov 13, 2023
The `ProcessListener` is made persistable by deriving it, as well as the `EventHelper` class from `persistence.Savable`. The class `EventHelper` is moved to a new file because of a circular import that would result between the `utils` and `persistence` modules. There was a circular reference issue in the test listener that was storing a reference to the process inside it, making its serialization impossible. To fix the tests an ugly hack was used: storing the reference to the process outside the class in a global dict using id as keys. Some more ugly hacks were needed to correctly check the equality of two processes. Instances having different listeners should be ignored. Cherry-pick: 98a375f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #273
We implement the persistence of ProcessListener by deriving the class ProcessListener and EventHelper from persistence.Savable. The class EventHelper is moved to a new file because of a circular import with utils and persistence
There was a circular reference issue in the test listener that was storing a reference to the process inside it, making its serialization impossible. To fix the tests an ugly hack was used: storing the reference to the process outside the class in a global dict using id as keys. Some more ugly hacks are needed to check correctly the equality of two processes. We must ignore the fact that the instances if the listener are different.
We call del on dict items of the ProcessListener's global implemented in the test suite to clean the golbal variables
addressed issues in #274