Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Duplicate Message #262

Closed
wants to merge 2 commits into from
Closed

Removed Duplicate Message #262

wants to merge 2 commits into from

Conversation

AlajeBash
Copy link

@AlajeBash AlajeBash commented Mar 10, 2023

To remove the Duplicate Message Definition i combine the point.fb and point2d.fb file together and remove the duplicated namespace seerep.fb; line. Here's how the code look like:

namespace seerep.fb;

table Point2D {
  x: double;
  y: double;
}

table Point {
  x: double;
  y: double;
  z: double;
}

I remove the Duplicate Message Definition by Merging the two Separate Files in to one File, and with this we will have a valid FlatBuffers schema with no duplicate message definitions.
No need for Point2d.fbs since we merge our two points files together
@jarkenau
Copy link
Member

That's not really was #261 is about. Either the definition of the Point or Vector3 can be removed since they are essential the same. This additionally requires checking if other messages depend on it. I would tend to call the resulting message Point3D, since it's more consistent with Point2D. If you change the PR in that way we can merge it.

@jarkenau jarkenau closed this Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants