Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add linux arm64 images to the build process #405

Merged
merged 2 commits into from
Oct 21, 2023

Conversation

ivan-leschinsky
Copy link
Contributor

@ivan-leschinsky ivan-leschinsky commented Oct 11, 2023

@johnboyes
Copy link
Contributor

Hi @ivan-leschinsky, thanks for the contribution - I'll review it in the next couple of days, hopefully Sunday 👍🏻

@johnboyes johnboyes added the minor Semantic versioning: new functionality that is backwards compatible label Oct 21, 2023
@johnboyes johnboyes merged commit 8470ae2 into agilepathway:master Oct 21, 2023
17 of 22 checks passed
@johnboyes
Copy link
Contributor

Released in v1.6.0 - thanks again @ivan-leschinsky for the contribution 🙏🏻

@ivan-leschinsky ivan-leschinsky deleted the add-linux-arm-images branch October 30, 2023 11:49
johnboyes added a commit that referenced this pull request Jan 19, 2024
A recent change, #405, which added ARM64 Docker images to the build
process, introduced a bug whereby the new Docker images for each release
are no longer being tagged `latest`, as they should be.  This commit
adds a test to catch this bug, and we will fix the bug in a subsequent
commit.
johnboyes added a commit that referenced this pull request Jan 19, 2024
A recent change, #405, which added ARM64 Docker images to the build
process, introduced a bug whereby the new Docker images for each release
are no longer being tagged `latest`, as they should be.  This commit
adds a test to catch this bug, and we will fix the bug in a subsequent
commit.
johnboyes added a commit that referenced this pull request Jan 19, 2024
A recent change, #405, which added ARM64 Docker images to the build
process, introduced a bug (see #419) whereby the new Docker images for
each release are no longer being tagged `latest`, as they should be.
This commit adds a test to catch this bug, and we will then fix the bug
in a subsequent commit.
johnboyes added a commit that referenced this pull request Jan 19, 2024
A recent change, #405, which added ARM64 Docker images to the build
process, introduced a bug (see #419) whereby the new Docker images for
each release are no longer being tagged `latest`, as they should be.
This commit adds a test to catch this bug, and we will then fix the bug
in a subsequent commit.
johnboyes added a commit that referenced this pull request Jan 19, 2024
A recent change, #405, which added ARM64 Docker images to the build
process, introduced a bug (see #419) whereby the new Docker images for
each release are no longer being tagged `latest`, as they should be.
This commit adds a test to catch this bug, and we will then fix the bug
in a subsequent commit.
johnboyes added a commit that referenced this pull request Jan 19, 2024
The bug was inadvertently introduced by #405, when we migrated to a
later version of the [Docker `build-push-action`][1].

[1]: https://github.com/docker/build-push-action

Fixes #419
johnboyes added a commit that referenced this pull request Jan 19, 2024
The bug was inadvertently introduced by #405, when we migrated to a
later version of the [Docker `build-push-action`][1].

[1]: https://github.com/docker/build-push-action

Fixes #419
johnboyes added a commit that referenced this pull request Jan 19, 2024
The bug was inadvertently introduced by #405, when we migrated to a
later version of the [Docker `build-push-action`][1].

[1]: https://github.com/docker/build-push-action

Fixes #419
johnboyes added a commit that referenced this pull request Jan 19, 2024
The bug was inadvertently introduced by #405, when we migrated to a
later version of the [Docker `build-push-action`][1].

[1]: https://github.com/docker/build-push-action

Fixes #419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Semantic versioning: new functionality that is backwards compatible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants