Skip to content

Commit

Permalink
Fix bug where Docker image was not tagged latest
Browse files Browse the repository at this point in the history
The bug was inadvertently introduced by #405, when we migrated to a
later version of the [Docker `build-push-action`][1].

[1]: https://github.com/docker/build-push-action

Fixes #419
  • Loading branch information
johnboyes authored Jan 19, 2024
1 parent 3153290 commit 8107ddc
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/github_tag_and_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ jobs:
- name: Build and push Docker image
uses: docker/build-push-action@v5
with:
tags: ${{env.docker_repo}}:${{ needs.tag.outputs.semver }}
tags: ${{env.docker_repo}}:${{ needs.tag.outputs.semver }},${{env.docker_repo}}:latest
platforms: linux/amd64,linux/arm64
push: true

Expand All @@ -78,6 +78,7 @@ jobs:
steps:

- name: Check Docker image for new release is tagged latest
# (it is important to have this check to catch any regression, e.g. if we move to a different way of releasing)
id: check_docker_image_tagged_latest
# yamllint disable rule:line-length
run: |
Expand Down

0 comments on commit 8107ddc

Please sign in to comment.