🐛 (import) fix qfx import crash if input is malformed file

[MatissJanis]

Closes #3519

[coderabbitai]

Walkthrough

The pull request primarily modifies the ImportTransactionsModal component in the ImportTransactionsModal.jsx file. It updates the destructuring of the parsedTransactions variable to ensure it defaults to an empty array, enhancing error handling when no transactions are returned. Additionally, minor adjustments, such as comments for clarity and improved function call structures, have been made. The overall functionality remains unchanged, focusing on transaction import and parsing.

Changes

File Path	Change Summary
.../ImportTransactionsModal.jsx	Updated destructuring of parsedTransactions to default to an empty array; added comments and improved readability.

Assessment against linked issues

Objective	Addressed	Explanation
Resolve import hanging issue (#3519)	✅

Possibly related PRs

• fix: csv import deduplication #3456: Modifies the ImportTransactionsModal.jsx file to enhance transaction data handling, closely related to the current changes.
• 🐛 (import) fix csv import checkboxes not working #3478: Involves changes to the ImportTransactionsModal.jsx file, specifically simplifying the import preview mechanism relevant to the import process.

Suggested labels

:sparkles: Merged

Suggested reviewers

• youngcw
• MikesGlitch

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	66fb1d2
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/66fd19adf34a340008e0b0d2
😎 Deploy Preview	https://deploy-preview-3541.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.29 MB → 5.29 MB (+5 B)	+0.00%

Changeset

File	Δ	Size
src/components/modals/ImportTransactionsModal.jsx	📈 +5 B (+0.01%)	51.97 kB → 51.97 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	3.31 MB → 3.31 MB (+5 B)	+0.00%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/usePreviewTransactions.js	1.64 kB	0%
static/js/AppliedFilters.js	20.96 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	81.98 kB	0%
static/js/wide.js	225.26 kB	0%
static/js/ReportRouter.js	1.5 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.19 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.19 MB	0%

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 5064b06 and 66fb1d2.

⛔ Files ignored due to path filters (1)

• upcoming-release-notes/3541.md is excluded by !**/*.md

📒 Files selected for processing (1)

• packages/desktop-client/src/components/modals/ImportTransactionsModal.jsx (1 hunks)

🔇 Additional comments (2)

packages/desktop-client/src/components/modals/ImportTransactionsModal.jsx (2)

1024-1024: Excellent defensive programming technique!

This change adds a fallback empty array for transactions if it's undefined. This is a great improvement that can prevent potential errors when trying to map over or process transactions later in the code. It directly addresses the PR objective of fixing a crash when importing a malformed QFX file.

---

1024-1024: Overall, this is a solid fix

The change successfully addresses the crash issue with malformed QFX files as described in the PR objectives. It's a minimal yet effective solution that improves the robustness of the import process without introducing unnecessary complexity.

The suggested addition of error logging could further enhance debugging capabilities, but the current implementation is already a significant improvement.