Fix suggested payee issues #3317 #3316

[qedi-r]

Fix issue #3317 by adding tombstone filter to common payee query.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	8541742
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/66cbbf92e16b190008820d0d
😎 Deploy Preview	https://deploy-preview-3318.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	5.2 MB → 5.2 MB (+25 B)	+0.00%

Changeset

File	Δ	Size
src/components/transactions/TransactionsTable.jsx	📈 +25 B (+0.04%)	63.42 kB → 63.44 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/wide.js	222.56 kB → 222.59 kB (+25 B)	+0.01%

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/usePreviewTransactions.js	1.59 kB	0%
static/js/AppliedFilters.js	21.01 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	77.58 kB	0%
static/js/ReportRouter.js	1.49 MB	0%
static/js/index.js	3.25 MB	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.16 MB → 1.19 MB (+33.28 kB)	+2.81%

Changeset

File	Δ	Size
node_modules/date-fns/esm/parse/index.js	🆕 +32.58 kB	0 B → 32.58 kB
node_modules/date-fns/esm/parse/_lib/parsers/index.js	🆕 +5.66 kB	0 B → 5.66 kB
node_modules/date-fns/esm/parse/_lib/parsers/StandAloneLocalDayParser.js	🆕 +3.52 kB	0 B → 3.52 kB
node_modules/date-fns/esm/parse/_lib/parsers/LocalDayParser.js	🆕 +3.44 kB	0 B → 3.44 kB
node_modules/date-fns/esm/parse/_lib/utils.js	🆕 +3.44 kB	0 B → 3.44 kB
node_modules/date-fns/esm/parse/_lib/parsers/ISODayParser.js	🆕 +3.4 kB	0 B → 3.4 kB
node_modules/date-fns/esm/parse/_lib/parsers/StandAloneMonthParser.js	🆕 +3.08 kB	0 B → 3.08 kB
node_modules/date-fns/esm/parse/_lib/parsers/MonthParser.js	🆕 +3.01 kB	0 B → 3.01 kB
node_modules/date-fns/esm/parse/_lib/parsers/YearParser.js	🆕 +2.9 kB	0 B → 2.9 kB
node_modules/date-fns/esm/parse/_lib/parsers/DayParser.js	🆕 +2.85 kB	0 B → 2.85 kB
node_modules/date-fns/esm/parse/_lib/parsers/StandAloneQuarterParser.js	🆕 +2.84 kB	0 B → 2.84 kB
node_modules/date-fns/esm/parse/_lib/Setter.js	🆕 +2.81 kB	0 B → 2.81 kB
node_modules/date-fns/esm/parse/_lib/parsers/LocalWeekYearParser.js	🆕 +2.8 kB	0 B → 2.8 kB
node_modules/date-fns/esm/parse/_lib/parsers/QuarterParser.js	🆕 +2.77 kB	0 B → 2.77 kB
node_modules/date-fns/esm/parse/_lib/parsers/DateParser.js	🆕 +2.41 kB	0 B → 2.41 kB
node_modules/date-fns/esm/parse/_lib/parsers/DayPeriodParser.js	🆕 +2.31 kB	0 B → 2.31 kB
node_modules/date-fns/esm/parse/_lib/parsers/AMPMMidnightParser.js	🆕 +2.28 kB	0 B → 2.28 kB
node_modules/date-fns/esm/parse/_lib/parsers/DayOfYearParser.js	🆕 +2.24 kB	0 B → 2.24 kB
node_modules/date-fns/esm/parse/_lib/parsers/AMPMParser.js	🆕 +2.23 kB	0 B → 2.23 kB
node_modules/date-fns/esm/parse/_lib/parsers/ISOTimezoneWithZParser.js	🆕 +2.13 kB	0 B → 2.13 kB
node_modules/date-fns/esm/parse/_lib/parsers/Hour1to12Parser.js	🆕 +2.1 kB	0 B → 2.1 kB
node_modules/date-fns/esm/parse/_lib/parsers/LocalWeekParser.js	🆕 +2.09 kB	0 B → 2.09 kB
node_modules/date-fns/esm/parse/_lib/parsers/ISOTimezoneParser.js	🆕 +2.08 kB	0 B → 2.08 kB
node_modules/date-fns/esm/parse/_lib/parsers/ISOWeekParser.js	🆕 +2.07 kB	0 B → 2.07 kB
node_modules/date-fns/esm/parse/_lib/parsers/EraParser.js	🆕 +2.03 kB	0 B → 2.03 kB
node_modules/date-fns/esm/parse/_lib/parsers/Hour0To11Parser.js	🆕 +2.02 kB	0 B → 2.02 kB
node_modules/date-fns/esm/parse/_lib/parsers/Hour1To24Parser.js	🆕 +1.94 kB	0 B → 1.94 kB
node_modules/date-fns/esm/parse/_lib/parsers/Hour0to23Parser.js	🆕 +1.89 kB	0 B → 1.89 kB
node_modules/date-fns/esm/parse/_lib/parsers/MinuteParser.js	🆕 +1.85 kB	0 B → 1.85 kB
node_modules/date-fns/esm/parse/_lib/parsers/SecondParser.js	🆕 +1.84 kB	0 B → 1.84 kB
node_modules/date-fns/esm/_lib/setUTCDay/index.js	🆕 +1.84 kB	0 B → 1.84 kB
node_modules/date-fns/esm/parse/_lib/parsers/ISOWeekYearParser.js	🆕 +1.82 kB	0 B → 1.82 kB
node_modules/date-fns/esm/parse/_lib/parsers/FractionOfSecondParser.js	🆕 +1.64 kB	0 B → 1.64 kB
node_modules/date-fns/esm/parse/_lib/parsers/ExtendedYearParser.js	🆕 +1.62 kB	0 B → 1.62 kB
node_modules/date-fns/esm/parse/_lib/parsers/TimestampMillisecondsParser.js	🆕 +1.51 kB	0 B → 1.51 kB
node_modules/date-fns/esm/parse/_lib/parsers/TimestampSecondsParser.js	🆕 +1.48 kB	0 B → 1.48 kB
node_modules/@babel/runtime/helpers/esm/createForOfIteratorHelper.js	🆕 +1.23 kB	0 B → 1.23 kB
node_modules/date-fns/esm/parse/_lib/constants.js	🆕 +1.15 kB	0 B → 1.15 kB
node_modules/date-fns/esm/parse/_lib/Parser.js	🆕 +1.01 kB	0 B → 1.01 kB
node_modules/date-fns/esm/_lib/setUTCISODay/index.js	🆕 +599 B	0 B → 599 B
node_modules/@babel/runtime/helpers/esm/createSuper.js	🆕 +557 B	0 B → 557 B
node_modules/@babel/runtime/helpers/esm/createClass.js	🆕 +507 B	0 B → 507 B
node_modules/@babel/runtime/helpers/esm/unsupportedIterableToArray.js	🆕 +497 B	0 B → 497 B
node_modules/date-fns/esm/_lib/setUTCISOWeek/index.js	🆕 +476 B	0 B → 476 B
node_modules/date-fns/esm/_lib/setUTCWeek/index.js	🆕 +470 B	0 B → 470 B
node_modules/@babel/runtime/helpers/esm/inherits.js	🆕 +460 B	0 B → 460 B
node_modules/@babel/runtime/helpers/esm/toPrimitive.js	🆕 +407 B	0 B → 407 B
node_modules/@babel/runtime/helpers/esm/possibleConstructorReturn.js	🆕 +403 B	0 B → 403 B
node_modules/date-fns/esm/_lib/assign/index.js	🆕 +345 B	0 B → 345 B
node_modules/@babel/runtime/helpers/esm/isNativeReflectConstruct.js	🆕 +308 B	0 B → 308 B
node_modules/@babel/runtime/helpers/esm/defineProperty.js	🆕 +286 B	0 B → 286 B
node_modules/@babel/runtime/helpers/esm/getPrototypeOf.js	🆕 +244 B	0 B → 244 B
node_modules/@babel/runtime/helpers/esm/setPrototypeOf.js	🆕 +232 B	0 B → 232 B
node_modules/@babel/runtime/helpers/esm/toPropertyKey.js	🆕 +227 B	0 B → 227 B
node_modules/@babel/runtime/helpers/esm/assertThisInitialized.js	🆕 +203 B	0 B → 203 B
node_modules/@babel/runtime/helpers/esm/arrayLikeToArray.js	🆕 +195 B	0 B → 195 B
node_modules/@babel/runtime/helpers/esm/classCallCheck.js	🆕 +156 B	0 B → 156 B
packages/loot-core/src/server/db/index.ts	📈 +150 B (+0.80%)	18.34 kB → 18.49 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
kcab.worker.js	1.16 MB → 1.19 MB (+33.28 kB)	+2.81%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

[qedi-r]

This also fixes my large mistake never implementing the 3 months ago part of the query to find common payees.

[qedi-r]

The fix for #3316 is included; this fixes the display of the payee list when no account is yet selected, which is the list that favourite payees is found in.

[psybers]

Did something not get committed? The diff contains no string tombstone in it anywhere.

[qedi-r]

Yep, I merging both clobbered the tombstone line. I've re-added it.

[qedi-r]

Added a couple of tests for the bugfixes.

[MatissJanis]

cc @psybers would you please mind verifying if this patch fixes the linked bug issues?

[psybers]

@MatissJanis yes, it fixed both reported bugs. But introduced a new bug. Favorites used to be sorted to the top of the suggestions, now they are not:

[qedi-r]

I'm not sure it did sort favourites first, common second in the list - it sorted them with localeCompare before display, and that has not changed.

[qedi-r]

If we like that better, where favorites are at the top, I can add that though. I'll do it in a new bug, though.

[psybers]

Don't include that here. It was just an artifact of the specific payees I selected while testing. The existing behavior does not sort.

[qedi-r]

Yep. To clarify: is this additional sorting desired behavior? I'm uncertain it is. Should I open a new bug for that?

[psybers]

You can open an issue. I would upvote it. I desire that behavior. ;-)

[MatissJanis]

My 2cents: agreed that favorites should be at the top. If they are not there - what purpose do they serve? Just an icon besides them? That's not really rhat useful. But putting them at the top if the list: definitely useful.

[matt-fidd]

Change looks good to me! Thanks for the fix