[Bug]: Suggested Payees is inconsistent

[psybers]

Verified issue does not already exist?

• I have searched and found no existing issue
• I will be providing steps how to reproduce the bug (in most cases this will also mean uploading a demo budget file)

What happened?

If you view the suggested payees, after favoriting two, you might see something like this:

But if you then go to add a new transaction, the payee list looks like this:

It seems to forget to show the favorites.

Where are you hosting Actual?

Docker

What browsers are you seeing the problem on?

Chrome

Operating System

Mac OSX

[psybers]

Related to #2814.

@qedi-r might want to take a look.

[qedi-r]

This seems to be limited to the case where you are selecting the payee without an account selected. Investigating what is different in this path.

[qedi-r]

Ah, I guess it's time to fix this then: #2814 (comment)

[psybers]

Ah, I guess it's time to fix this then: #2814 (comment)

I'm not entirely sure the two are related, but maybe. Either way I guess we can try to fix that here.

[qedi-r]

My assumption here is that not displaying any payees when an account is not yet selected on new transactions is the bug as shown below:

if this is fixed, then the missing favorites is also fixed. The fix is the payees.filter line 1243 on TransactionTable.tsx.

If this is intended to not display payees, then we need to know when this is the case, and not add common payees to this list.