Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n: Use 'en' as default language #3242

Merged
merged 2 commits into from
Aug 12, 2024
Merged

fix: i18n: Use 'en' as default language #3242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
732161b
fix: i18n: Use 'en' as default language
julianwachholz Aug 12, 2024
1b15110
Add release note
julianwachholz Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/desktop-client/src/i18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,8 @@ i18n
.init({
// While we mark all strings for translations, one can test
// it by setting the language in localStorage to their choice.
lng: localStorage.getItem('language') || 'cimode',
// Set this to 'cimode' to see the exact keys without interpolation.
lng: localStorage.getItem('language') || 'en',

// allow keys to be phrases having `:`, `.`
nsSeparator: false,
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/3242.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Bugfix
authors: [julianwachholz]
---

Fixed translation keys being shown verbatim without interpolation
Loading