Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: i18n: Use 'en' as default language #3242

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

julianwachholz
Copy link
Contributor

Using 'cimode' as default language code will return the translation keys verbatim without doing interpolation. This is unwanted unless working directly on localization.

Fixes #3240

Using 'cimode' as default language code will return the
translation keys verbatim without doing interpolation.
This is unwanted unless working directly on localization.

Fixes actualbudget#3240
@actual-github-bot actual-github-bot bot changed the title fix: i18n: Use 'en' as default language [WIP] fix: i18n: Use 'en' as default language Aug 12, 2024
Copy link

netlify bot commented Aug 12, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 1b15110
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/66b9b0fb54649800086c11c0
😎 Deploy Preview https://deploy-preview-3242.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Aug 12, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
9 4.92 MB → 4.92 MB (+67 B) +0.00%
Changeset
File Δ Size
src/i18n.ts 📈 +67 B (+10.21%) 656 B → 723 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 3.19 MB → 3.19 MB (+67 B) +0.00%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/usePreviewTransactions.js 790 B 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/AppliedFilters.js 27.55 kB 0%
static/js/narrow.js 77.55 kB 0%
static/js/wide.js 246.2 kB 0%
static/js/ReportRouter.js 1.24 MB 0%

Copy link
Contributor

github-actions bot commented Aug 12, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.14 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.14 MB 0%

@julianwachholz julianwachholz changed the title [WIP] fix: i18n: Use 'en' as default language fix: i18n: Use 'en' as default language Aug 12, 2024
Copy link
Contributor

@MikesGlitch MikesGlitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@MikesGlitch MikesGlitch merged commit a221605 into actualbudget:master Aug 12, 2024
19 checks passed
@julianwachholz julianwachholz deleted the fix-i18n-fallback branch August 12, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Selecting any number of transactions does not display the # of transactoins selected
2 participants