-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Reset Hold and Hold For Next Month api #3140
Merged
MatissJanis
merged 10 commits into
actualbudget:master
from
rodriguestiago0:add_reset_hold_and_hold_for_next_month
Aug 4, 2024
Merged
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
81b843b
Add Reset Hold and Hold For Next Month api
rodriguestiago0 0028cf8
Add release notes
rodriguestiago0 a205b51
Update packages/api/methods.ts
rodriguestiago0 617cc7e
Update packages/api/methods.ts
rodriguestiago0 fc55156
fixed api handlers
rodriguestiago0 6b26098
handlers
rodriguestiago0 727d740
Merge branch 'master' into add_reset_hold_and_hold_for_next_month
rodriguestiago0 6ae3306
rename api path
rodriguestiago0 b06880f
Merge branch 'add_reset_hold_and_hold_for_next_month' of github.com:r…
rodriguestiago0 50522fa
Merge branch 'master' into add_reset_hold_and_hold_for_next_month
rodriguestiago0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
category: Enhancements | ||
authors: [rodriguestiago0] | ||
--- | ||
|
||
Add `reset-hold` and `hold-for-next-month` methods to the API |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought I had is it might be good to call this
budget-hold-for-next-month
(and use the same pattern for the other endpoint) vs the currenthold-budget-for-next-month
. My thought process is that the former sounds more like you're holding an amount from the budget for next month (the additive nature of the feature), whereas the latter is holding the entire budget. Doing the former also matches previous endpoints in the file (e.g.budget-set-amount
,budget-set-carryover
)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree. Changing it