Add Reset Hold and Hold For Next Month api #3140

rodriguestiago0 · 2024-07-26T17:20:58Z

netlify · 2024-07-26T17:21:13Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`50522fa`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/66ac1a7e7e4d240008f23545
😎 Deploy Preview	https://deploy-preview-3140.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-07-26T17:23:18Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
9	4.8 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/narrow.js	78.27 kB	0%
static/js/usePreviewTransactions.js	790 B	0%
static/js/AppliedFilters.js	27.61 kB	0%
static/js/wide.js	277.26 kB	0%
static/js/ReportRouter.js	1.23 MB	0%
static/js/index.js	3.04 MB	0%

github-actions · 2024-07-26T17:23:19Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.14 MB → 1.14 MB (+334 B)	+0.03%

Changeset

File	Δ	Size
`packages/loot-core/src/server/api.ts`	📈 +538 B (+2.69%)	19.5 kB → 20.03 kB
`packages/api/methods.ts`	📈 +278 B (+1.95%)	13.92 kB → 14.19 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
kcab.worker.js	1.14 MB → 1.14 MB (+334 B)	+0.03%

Smaller

No assets were smaller

Unchanged

No assets were unchanged

MatissJanis

Thanks for working on this!

packages/api/methods.ts

Co-authored-by: Matiss Janis Aboltins <[email protected]>

MatissJanis

LGTM on my end.

Looking for another maintainers review since this impacts the API (which we cannot easily change without introducing a breaking change).

matt-fidd

Thanks for this! LGTM

jfdoming · 2024-08-01T20:46:58Z

packages/loot-core/src/types/api-handlers.d.ts

@@ -63,6 +63,13 @@ export interface ApiHandlers {
    flag: boolean;
  }) => Promise<void>;

+  'api/hold-budget-for-next-month': (arg: {


One thought I had is it might be good to call this budget-hold-for-next-month (and use the same pattern for the other endpoint) vs the current hold-budget-for-next-month. My thought process is that the former sounds more like you're holding an amount from the budget for next month (the additive nature of the feature), whereas the latter is holding the entire budget. Doing the former also matches previous endpoints in the file (e.g. budget-set-amount, budget-set-carryover)

I agree. Changing it

…odriguestiago0/actual into add_reset_hold_and_hold_for_next_month

jfdoming

Thanks!

Docs for [PR](actualbudget/actual#3140)

jat255 · 2024-09-08T03:00:52Z

This also addressed the feature request in #1982

Add Reset Hold and Hold For Next Month api

81b843b

actual-github-bot bot changed the title ~~Add Reset Hold and Hold For Next Month api~~ [WIP] Add Reset Hold and Hold For Next Month api Jul 26, 2024

actual-github-bot bot added the 🚧 WIP label Jul 26, 2024

Add release notes

0028cf8

rodriguestiago0 force-pushed the add_reset_hold_and_hold_for_next_month branch from 867c26b to 0028cf8 Compare July 26, 2024 17:33

rodriguestiago0 changed the title ~~[WIP] Add Reset Hold and Hold For Next Month api~~ Add Reset Hold and Hold For Next Month api Jul 26, 2024

actual-github-bot bot added 🔍 Ready for review and removed 🚧 WIP labels Jul 26, 2024

MatissJanis reviewed Jul 27, 2024

View reviewed changes

packages/api/methods.ts Outdated Show resolved Hide resolved

packages/api/methods.ts Outdated Show resolved Hide resolved

rodriguestiago0 and others added 4 commits July 27, 2024 22:13

Update packages/api/methods.ts

a205b51

Co-authored-by: Matiss Janis Aboltins <[email protected]>

Update packages/api/methods.ts

617cc7e

Co-authored-by: Matiss Janis Aboltins <[email protected]>

fixed api handlers

fc55156

handlers

6b26098

rodriguestiago0 requested a review from MatissJanis July 29, 2024 10:08

Merge branch 'master' into add_reset_hold_and_hold_for_next_month

727d740

MatissJanis previously approved these changes Jul 29, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Jul 29, 2024

matt-fidd previously approved these changes Jul 29, 2024

View reviewed changes

jfdoming reviewed Aug 1, 2024

View reviewed changes

rodriguestiago0 added 2 commits August 2, 2024 00:29

rename api path

6ae3306

Merge branch 'add_reset_hold_and_hold_for_next_month' of github.com:r…

b06880f

…odriguestiago0/actual into add_reset_hold_and_hold_for_next_month

rodriguestiago0 dismissed stale reviews from matt-fidd and MatissJanis via b06880f August 1, 2024 23:29

actual-github-bot bot added 🔍 Ready for review and removed ✅ Approved labels Aug 1, 2024

Merge branch 'master' into add_reset_hold_and_hold_for_next_month

50522fa

rodriguestiago0 mentioned this pull request Aug 1, 2024

Add documentation for holdBudgetForNextMonth and resetBudgetHold actualbudget/docs#420

Merged

rodriguestiago0 requested review from jfdoming, matt-fidd and MatissJanis August 1, 2024 23:36

jfdoming approved these changes Aug 1, 2024

View reviewed changes

actual-github-bot bot added ✅ Approved and removed 🔍 Ready for review labels Aug 1, 2024

MatissJanis approved these changes Aug 3, 2024

View reviewed changes

MatissJanis merged commit 2b1ba88 into actualbudget:master Aug 4, 2024
19 checks passed

actual-github-bot bot added ✨ Merged and removed ✅ Approved labels Aug 4, 2024

MatissJanis pushed a commit to actualbudget/docs that referenced this pull request Aug 6, 2024

Add documentation for holdBudgetForNextMonth and resetBudgetHold (#420)

2f272b9

Docs for [PR](actualbudget/actual#3140)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Reset Hold and Hold For Next Month api #3140

Add Reset Hold and Hold For Next Month api #3140

rodriguestiago0 commented Jul 26, 2024 •

edited

Loading

netlify bot commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024 •

edited

Loading

MatissJanis left a comment

MatissJanis left a comment

matt-fidd left a comment

jfdoming Aug 1, 2024

rodriguestiago0 Aug 1, 2024

jfdoming left a comment

jat255 commented Sep 8, 2024

Add Reset Hold and Hold For Next Month api #3140

Add Reset Hold and Hold For Next Month api #3140

Conversation

rodriguestiago0 commented Jul 26, 2024 • edited Loading

netlify bot commented Jul 26, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Jul 26, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Jul 26, 2024 • edited Loading

Bundle Stats — loot-core

MatissJanis left a comment

Choose a reason for hiding this comment

MatissJanis left a comment

Choose a reason for hiding this comment

matt-fidd left a comment

Choose a reason for hiding this comment

jfdoming Aug 1, 2024

Choose a reason for hiding this comment

rodriguestiago0 Aug 1, 2024

Choose a reason for hiding this comment

jfdoming left a comment

Choose a reason for hiding this comment

jat255 commented Sep 8, 2024

rodriguestiago0 commented Jul 26, 2024 •

edited

Loading

netlify bot commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024 •

edited

Loading