Add crdt to the API package to fix types #2738
Conversation
github-actions
bot
changed the title
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -15,6 +15,7 @@ config.resolve.extensions = [ | |||
| '.json', | |||
| ]; | |||
| config.resolve.fallback = {}; | |||
| config.externals.push('@actual-app/crdt'); | |||
There was a problem hiding this comment.
Not necessary, but if we are going to depend on the package in the api, might as well use it rather than have it in the webpack bundle. I did confirm the built API was still working after this change. By importing some transactions via the api.
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
- This way we get the crdt types supported
twk3
changed the title
trafico-bot
bot
added
✨ Merged
Instead of adding crdt as a dependency, I did confirm we could generate just the crdt types and copy them into the api like we do for loot-core. But then we still get an error regarding the google-protobuf types missing. Which is fixed by adding google-protobuf to our api dependencies. Being that a dependency needed to be added to the api either way, I just did the crdt one for now (which includes the google-protobuf dependency)
I believe this is the final unblocker for shipping the types with the API in #2559