Skip to content

Commit

Permalink
Add crdt to the API package to fix types (#2738)
Browse files Browse the repository at this point in the history
* Add crdt to the API package to fix types

- This way we get the crdt types supported

* Add release note

* Cleanup yarn.lock merge
  • Loading branch information
twk3 authored May 18, 2024
1 parent c311d4a commit f604fda
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 9 deletions.
1 change: 1 addition & 0 deletions packages/api/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"clean": "rm -rf dist @types"
},
"dependencies": {
"@actual-app/crdt": "workspace:^",
"better-sqlite3": "^9.6.0",
"compare-versions": "^6.1.0",
"node-fetch": "^3.3.2",
Expand Down
1 change: 1 addition & 0 deletions packages/loot-core/webpack/webpack.api.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ config.resolve.extensions = [
'.json',
];
config.resolve.fallback = {};
config.externals.push('@actual-app/crdt');
config.output.filename = 'bundle.api.js';
config.output.sourceMapFilename = 'bundle.api.js.map';
config.output.path = path.join(
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/2738.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [twk3]
---

Include crdt as a dependency in the API to include its types
12 changes: 3 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ __metadata:
version: 0.0.0-use.local
resolution: "@actual-app/api@workspace:packages/api"
dependencies:
"@actual-app/crdt": "workspace:^"
"@swc/core": "npm:^1.5.3"
"@swc/jest": "npm:^0.2.36"
"@types/jest": "npm:^27.5.2"
Expand All @@ -37,7 +38,7 @@ __metadata:
languageName: unknown
linkType: soft

"@actual-app/crdt@npm:*, @actual-app/crdt@workspace:packages/crdt":
"@actual-app/crdt@npm:*, @actual-app/crdt@workspace:^, @actual-app/crdt@workspace:packages/crdt":
version: 0.0.0-use.local
resolution: "@actual-app/crdt@workspace:packages/crdt"
dependencies:
Expand Down Expand Up @@ -5527,14 +5528,7 @@ __metadata:
languageName: node
linkType: hard

"@types/node@npm:*":
version: 18.16.3
resolution: "@types/node@npm:18.16.3"
checksum: 4f4425ba49a46e7efa88346dc2ea63ea9aab88c04d244d77710fe8019587f3c163ba2ea1e4854fd20cb5cdec9abd3bfb324ad60aabddf395cee6b0b195bd57bb
languageName: node
linkType: hard

"@types/node@npm:^20.9.0":
"@types/node@npm:*, @types/node@npm:^20.9.0":
version: 20.12.11
resolution: "@types/node@npm:20.12.11"
dependencies:
Expand Down

0 comments on commit f604fda

Please sign in to comment.