Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable reconciliation when importing OFX files. #2564

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

keriati
Copy link
Contributor

@keriati keriati commented Apr 7, 2024

This PR adds a checkbox when importing OFX files to disable reconciliation.
It addresses the problems highlighted in issues: #2420 #608

It implements the feature partially requested in #2561

Screenshot:
Screenshot 2024-04-07 at 11 04 39

Copy link

netlify bot commented Apr 7, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 6109cb5
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/661263f33d4e32000815cf96
😎 Deploy Preview https://deploy-preview-2564.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot changed the title Add option to disable reconciliation when importing OFX files. [WIP] Add option to disable reconciliation when importing OFX files. Apr 7, 2024
Copy link
Contributor

github-actions bot commented Apr 7, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
11 4.48 MB → 4.48 MB (+686 B) +0.01%
Changeset
File Δ Size
home/runner/work/actual/actual/packages/loot-core/src/client/actions/account.ts 📈 +162 B (+3.70%) 4.28 kB → 4.43 kB
src/components/modals/ImportTransactions.jsx 📈 +524 B (+1.36%) 37.68 kB → 38.19 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.55 MB → 2.56 MB (+686 B) +0.03%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/BalanceWithCarryover.js 1.43 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/narrow.js 216.88 kB 0%
static/js/import.js 105.26 kB 0%
static/js/wide.js 261.12 kB 0%
static/js/ReportRouter.js 1.18 MB 0%

Copy link
Contributor

github-actions bot commented Apr 7, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@keriati keriati force-pushed the ofx-no-reconcile branch 2 times, most recently from 258921a to 1c3a46c Compare April 7, 2024 09:13
@keriati keriati force-pushed the ofx-no-reconcile branch from 1c3a46c to 6109cb5 Compare April 7, 2024 09:14
@keriati keriati changed the title [WIP] Add option to disable reconciliation when importing OFX files. Add option to disable reconciliation when importing OFX files. Apr 7, 2024
@youngcw
Copy link
Member

youngcw commented Apr 7, 2024

Could we use a descriptor other than reconcile? Maybe merge or match. I don't want to accidentally cause people to confuse this option with reconcile to lock.

@keriati
Copy link
Contributor Author

keriati commented Apr 7, 2024

Could we use a descriptor other than reconcile? Maybe merge or match. I don't want to accidentally cause people to confuse this option with reconcile to lock.

I am open for suggestions. The idea for the naming comes from the fact that we are not using the reconcileTransactions() function but the addTransactions() instead.

@youngcw
Copy link
Member

youngcw commented Apr 8, 2024

Could we use a descriptor other than reconcile? Maybe merge or match. I don't want to accidentally cause people to confuse this option with reconcile to lock.

I am open for suggestions. The idea for the naming comes from the fact that we are not using the reconcileTransactions() function but the addTransactions() instead.

I think I would vote for "Merge with existing transactions" or "Update matching transactions"

Copy link
Member

@youngcw youngcw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionally this all seems good. @MatissJanis do you have any thoughts on the button labal?

@iListen2Sound
Copy link

Will this also work for CSV imports? I'm experiencing the exact same problem just with CSV instead of OFX

@youngcw
Copy link
Member

youngcw commented Apr 11, 2024

Ill merge this in for now so the people that this helps can use it. If the wording is confusing people its an easy fix

@youngcw youngcw merged commit 915c562 into actualbudget:master Apr 11, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 11, 2024
@keriati
Copy link
Contributor Author

keriati commented Apr 11, 2024

Will this also work for CSV imports? I'm experiencing the exact same problem just with CSV instead of OFX

No, however I might open another fix for CSV imports.

@kstockk
Copy link
Contributor

kstockk commented May 2, 2024

i found the wording very confusing and messed up my whole budget. undo wasn't working also for the import transactions

@strazto
Copy link
Contributor

strazto commented May 7, 2024

I backed up my budget before using this.
The wording is confusing, and the behaviour is not what i expected.

See #2618 (comment) for the behaviour I was expecting.

What I actually want is something like follows:

  • Treat transactions with similar dates and amounts as duplicates

The current wording is "Reconcile transactions", and its logic should be better expressed as:

  • Don't re-import duplicate transactions

@strazto
Copy link
Contributor

strazto commented May 7, 2024

i found the wording very confusing and messed up my whole budget. undo wasn't working also for the import transactions

Thank you for the warning. I backed up my file before attempting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants