-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to disable reconciliation when importing OFX files. #2564
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
258921a
to
1c3a46c
Compare
1c3a46c
to
6109cb5
Compare
Could we use a descriptor other than reconcile? Maybe merge or match. I don't want to accidentally cause people to confuse this option with reconcile to lock. |
I am open for suggestions. The idea for the naming comes from the fact that we are not using the reconcileTransactions() function but the addTransactions() instead. |
I think I would vote for "Merge with existing transactions" or "Update matching transactions" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionally this all seems good. @MatissJanis do you have any thoughts on the button labal?
Will this also work for CSV imports? I'm experiencing the exact same problem just with CSV instead of OFX |
Ill merge this in for now so the people that this helps can use it. If the wording is confusing people its an easy fix |
No, however I might open another fix for CSV imports. |
i found the wording very confusing and messed up my whole budget. undo wasn't working also for the import transactions |
I backed up my budget before using this. See #2618 (comment) for the behaviour I was expecting. What I actually want is something like follows:
The current wording is "Reconcile transactions", and its logic should be better expressed as:
|
Thank you for the warning. I backed up my file before attempting it. |
This PR adds a checkbox when importing OFX files to disable reconciliation.
It addresses the problems highlighted in issues: #2420 #608
It implements the feature partially requested in #2561
Screenshot: