Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable reconciliation when importing CSV and files. #2585

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

keriati
Copy link
Contributor

@keriati keriati commented Apr 11, 2024

This PR adds the Checkbox for reconciliation also to CSV imports.

Issue mentioned in: #2564 #2420 #608 #2561

Screenshot:
Screenshot 2024-04-11 at 21 58 19

Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 9800fd8
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6619485ab4070b00082ac9a9
😎 Deploy Preview https://deploy-preview-2585.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.62 MB → 4.62 MB (+338 B) +0.01%
Changeset
File Δ Size
src/components/modals/ImportTransactions.jsx 📈 +338 B (+0.86%) 38.19 kB → 38.52 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.56 MB → 2.56 MB (+338 B) +0.01%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/resize-observer.js 18.37 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/narrow.js 202.51 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/real-module.js 22.09 kB 0%
static/js/import.js 118.98 kB 0%
static/js/wide.js 371.33 kB 0%
static/js/ReportRouter.js 1.18 MB 0%

Copy link
Contributor

github-actions bot commented Apr 11, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@keriati keriati changed the title [WiP] Add option to disable reconciliation when importing CSV and files. Add option to disable reconciliation when importing CSV and files. Apr 11, 2024
@youngcw
Copy link
Member

youngcw commented Apr 11, 2024

Looks like the csv importer gets checked by the vrt. Are you able to get those screenshots updated?

@keriati
Copy link
Contributor Author

keriati commented Apr 12, 2024

Looks like the csv importer gets checked by the vrt. Are you able to get those screenshots updated?

Sadly I can't run this for now on Linux to update the screens.

Also the screens that are failing are actually not changed, it seems somehow the test runner is rendering a bit differently, I don't think this problem is related to my changes, rather some test runner issue.

I try to trigger it again.

@youngcw youngcw merged commit 345ea71 into actualbudget:master Apr 12, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants