[Mobile] Budget menu modals #2491

joel-jeremy · 2024-03-22T07:07:13Z

Removed Add group button and replaced with a + sign on page header
Added a menu on the left side of the page header for more budget menus
- (Will add budget actions e.g. goal template menus next)

netlify · 2024-03-22T07:07:27Z

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	`7c84297`
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/66156cdeb6d8bc00087638fd
😎 Deploy Preview	https://deploy-preview-2491.demo.actualbudget.org
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions · 2024-03-22T07:08:27Z

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
10	4.61 MB → 4.61 MB (-89 B)	-0.00%

Changeset

File	Δ	Size
`src/components/modals/SwitchBudgetTypeModal.tsx`	🆕 +1.83 kB	0 B → 1.83 kB
`src/components/modals/BudgetMenuModal.tsx`	🆕 +1.65 kB	0 B → 1.65 kB
`src/icons/logo/Logo.tsx`	🆕 +911 B	0 B → 911 B
`src/components/mobile/budget/index.tsx`	📈 +513 B (+6.02%)	8.33 kB → 8.83 kB
`src/components/Modals.tsx`	📈 +696 B (+5.54%)	12.27 kB → 12.95 kB
`src/components/common/Modal.tsx`	📈 +377 B (+3.83%)	9.61 kB → 9.98 kB
`src/components/modals/CategoryMenuModal.tsx`	📉 -80 B (-1.57%)	4.97 kB → 4.89 kB
`src/components/modals/AccountMenuModal.tsx`	📉 -80 B (-1.58%)	4.96 kB → 4.88 kB
`src/components/common/Menu.tsx`	📉 -112 B (-1.99%)	5.49 kB → 5.38 kB
`src/components/modals/ScheduledTransactionMenuModal.tsx`	📉 -28 B (-2.09%)	1.31 kB → 1.28 kB
`src/components/modals/CategoryGroupMenuModal.tsx`	📉 -222 B (-3.64%)	5.96 kB → 5.75 kB
`src/components/modals/RolloverBalanceMenuModal.tsx`	📉 -28 B (-3.77%)	743 B → 715 B
`src/components/modals/RolloverToBudgetMenuModal.tsx`	📉 -28 B (-3.80%)	737 B → 709 B
`src/components/modals/ReportBalanceMenuModal.tsx`	📉 -28 B (-4.06%)	689 B → 661 B
`src/components/mobile/budget/BudgetTable.jsx`	📉 -3.77 kB (-10.61%)	35.58 kB → 31.8 kB
`src/components/modals/SwitchBudgetType.tsx`	🔥 -1.63 kB (-100%)	1.63 kB → 0 B

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset	File Size	% Changed
static/js/index.js	2.56 MB → 2.56 MB (+3.19 kB)	+0.12%

Smaller

Asset	File Size	% Changed
static/js/narrow.js	205.49 kB → 202.22 kB (-3.27 kB)	-1.59%

Unchanged

Asset	File Size	% Changed
static/js/indexeddb-main-thread-worker-e59fee74.js	13.5 kB	0%
static/js/resize-observer.js	18.37 kB	0%
static/js/BackgroundImage.js	122.29 kB	0%
static/js/real-module.js	22.09 kB	0%
static/js/AppliedFilters.js	20.35 kB	0%
static/js/import.js	118.98 kB	0%
static/js/wide.js	370.57 kB	0%
static/js/ReportRouter.js	1.18 MB	0%

github-actions · 2024-03-22T07:08:28Z

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
1	1.2 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.2 MB	0%

MatissJanis

Overall LGTM

MatissJanis · 2024-04-06T18:48:14Z

upcoming-release-notes/2491.md

+authors: [joel-jeremy]
+---
+
+Mobile budget page menu modals.


🥜 nitpick: ‏a more detailed description would be better

MatissJanis · 2024-04-06T18:51:34Z

packages/desktop-client/src/components/modals/CategoryGroupMenuModal.tsx

+      title={
+        <ModalTitle isEditable title={group.name} onTitleUpdate={onRename} />
+      }


Could we remove left-padding from the mobile modal title?

The modal title is centered. That left margin is reserved for any additional menus e.g. category modal's hide and delete menus. Maybe I should reduce the font size.

trafico-bot bot added the 🔍 Ready for Review label Mar 22, 2024

joel-jeremy force-pushed the budget-add-category-or-group-menu branch from 9d004dd to f039bc6 Compare March 22, 2024 07:09

joel-jeremy changed the base branch from master to mobile-menu-modal March 22, 2024 07:12

joel-jeremy changed the title ~~Budget add category or group menu~~ [Mobile] Budget menu modals Mar 22, 2024

joel-jeremy force-pushed the budget-add-category-or-group-menu branch from 30f0dec to d18e561 Compare March 24, 2024 01:16

joel-jeremy force-pushed the mobile-menu-modal branch from f210346 to 14dc0cd Compare March 24, 2024 01:23

joel-jeremy force-pushed the budget-add-category-or-group-menu branch from d18e561 to faba272 Compare March 24, 2024 01:24

joel-jeremy mentioned this pull request Mar 24, 2024

[Mobile] Category budget actions modal #2501

Merged

joel-jeremy force-pushed the mobile-menu-modal branch from 14dc0cd to 2cfdee9 Compare March 25, 2024 15:35

joel-jeremy force-pushed the budget-add-category-or-group-menu branch from faba272 to 3b68eec Compare March 25, 2024 15:44

joel-jeremy added this to the v24.4.0 milestone Mar 26, 2024

joel-jeremy force-pushed the mobile-menu-modal branch from 9fba1cb to 888abe0 Compare March 26, 2024 16:35

joel-jeremy force-pushed the budget-add-category-or-group-menu branch from 3b68eec to 35c6969 Compare March 26, 2024 16:35

MatissJanis removed this from the v24.4.0 milestone Mar 26, 2024

joel-jeremy force-pushed the mobile-menu-modal branch from ddbfee4 to 29166fc Compare April 2, 2024 14:18

joel-jeremy force-pushed the budget-add-category-or-group-menu branch from 35c6969 to efed7c6 Compare April 2, 2024 14:20

joel-jeremy force-pushed the mobile-menu-modal branch from 29166fc to 901d0c4 Compare April 2, 2024 18:22

joel-jeremy force-pushed the budget-add-category-or-group-menu branch from efed7c6 to 90b3fd2 Compare April 2, 2024 18:23

joel-jeremy force-pushed the mobile-menu-modal branch from 901d0c4 to db44102 Compare April 2, 2024 21:13

joel-jeremy force-pushed the budget-add-category-or-group-menu branch 2 times, most recently from 4af60e9 to cd3eafe Compare April 4, 2024 04:28

Base automatically changed from mobile-menu-modal to master April 4, 2024 20:53

joel-jeremy force-pushed the budget-add-category-or-group-menu branch from cd3eafe to ff5e3b5 Compare April 4, 2024 21:26

joel-jeremy requested a review from MatissJanis April 4, 2024 22:17

MatissJanis previously approved these changes Apr 6, 2024

View reviewed changes

trafico-bot bot added ✅ Approved and removed 🔍 Ready for Review labels Apr 6, 2024

trafico-bot bot removed the 🔍 Ready for Review label Apr 7, 2024

joel-jeremy dismissed MatissJanis’s stale review via 8b86163 April 9, 2024 14:11

joel-jeremy force-pushed the budget-add-category-or-group-menu branch from edd1ca6 to 8b86163 Compare April 9, 2024 14:11

trafico-bot bot added 🔍 Ready for Review and removed ✅ Approved labels Apr 9, 2024

joel-jeremy added 15 commits April 9, 2024 09:28

Update autocomplete types

f0aec96

Remote optional type

c5f09e3

Improve SingleInputModal

4674461

Fix lint error

284ef73

Mobile budget page modals

16e9cf3

Release notes

53e4d5c

Fix typecheck / lint errors

04d3c1a

Fix typecheck errors

a9d9e85

Fix typecheck error

b8343f7

Modal logo

c6d2227

Fix typecheck error

7a5724f

VRT updates

10b2e16

Modal header margins

0436d17

Update 2491.md

ee6137a

ModalTitle shrinkOnOverflow + VRT

7c84297

joel-jeremy force-pushed the budget-add-category-or-group-menu branch from 2353b6a to 7c84297 Compare April 9, 2024 16:29

joel-jeremy requested a review from MatissJanis April 9, 2024 17:01

joel-jeremy mentioned this pull request Apr 11, 2024

Use desktop colors for mobile autocomplete modals #2577

Merged

shall0pass approved these changes Apr 11, 2024

View reviewed changes

trafico-bot bot added ✅ Approved and removed 🔍 Ready for Review labels Apr 11, 2024

joel-jeremy merged commit f55bd86 into master Apr 11, 2024
19 checks passed

joel-jeremy deleted the budget-add-category-or-group-menu branch April 11, 2024 19:41

trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Mobile] Budget menu modals #2491

[Mobile] Budget menu modals #2491

joel-jeremy commented Mar 22, 2024 •

edited

Loading

netlify bot commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

MatissJanis left a comment

MatissJanis Apr 6, 2024

MatissJanis Apr 6, 2024

joel-jeremy Apr 6, 2024 •

edited

Loading

[Mobile] Budget menu modals #2491

[Mobile] Budget menu modals #2491

Conversation

joel-jeremy commented Mar 22, 2024 • edited Loading

netlify bot commented Mar 22, 2024 • edited Loading

✅ Deploy Preview for actualbudget ready!

github-actions bot commented Mar 22, 2024 • edited Loading

Bundle Stats — desktop-client

github-actions bot commented Mar 22, 2024 • edited Loading

Bundle Stats — loot-core

MatissJanis left a comment

Choose a reason for hiding this comment

MatissJanis Apr 6, 2024

Choose a reason for hiding this comment

MatissJanis Apr 6, 2024

Choose a reason for hiding this comment

joel-jeremy Apr 6, 2024 • edited Loading

Choose a reason for hiding this comment

joel-jeremy commented Mar 22, 2024 •

edited

Loading

netlify bot commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

github-actions bot commented Mar 22, 2024 •

edited

Loading

joel-jeremy Apr 6, 2024 •

edited

Loading