Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use desktop colors for mobile autocomplete modals #2577

Merged
merged 8 commits into from
Apr 11, 2024

Conversation

joel-jeremy
Copy link
Contributor

@joel-jeremy joel-jeremy commented Apr 10, 2024

Closes #2574

This also lessens the pain of managing different color schemes for desktop and mobile auto complete components.

@github-actions github-actions bot changed the title Use desktop colors for mobile autocomplete modals [WIP] Use desktop colors for mobile autocomplete modals Apr 10, 2024
Copy link

netlify bot commented Apr 10, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit a7d11ac
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6618442f12ef7700078c4004
😎 Deploy Preview https://deploy-preview-2577.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.62 MB → 4.62 MB (+217 B) +0.00%
Changeset
File Δ Size
src/components/modals/PayeeAutocompleteModal.tsx 📈 +252 B (+20.16%) 1.22 kB → 1.47 kB
src/components/modals/AccountAutocompleteModal.tsx 📈 +257 B (+16.13%) 1.56 kB → 1.81 kB
src/components/modals/CategoryAutocompleteModal.tsx 📈 +257 B (+15.74%) 1.59 kB → 1.85 kB
src/components/autocomplete/AccountAutocomplete.tsx 📈 +99 B (+2.00%) 4.84 kB → 4.94 kB
src/components/gocardless/GoCardlessLink.tsx 📈 +3 B (+0.49%) 618 B → 621 B
src/components/MobileWebMessage.tsx 📈 +10 B (+0.34%) 2.87 kB → 2.88 kB
src/components/FatalError.tsx 📈 +3 B (+0.05%) 6.46 kB → 6.46 kB
src/components/common/Modal.tsx 📈 +3 B (+0.03%) 9.98 kB → 9.98 kB
src/components/mobile/transactions/Option.jsx 📉 -6 B (-0.78%) 770 B → 764 B
src/components/modals/EditField.jsx 📉 -67 B (-0.80%) 8.2 kB → 8.13 kB
src/components/autocomplete/PayeeAutocomplete.tsx 📉 -123 B (-0.97%) 12.36 kB → 12.24 kB
src/style/themes/light.ts 📉 -74 B (-1.02%) 7.11 kB → 7.04 kB
src/style/themes/dark.ts 📉 -74 B (-1.03%) 7.04 kB → 6.97 kB
src/style/themes/development.ts 📉 -74 B (-1.04%) 6.95 kB → 6.88 kB
src/style/themes/midnight.ts 📉 -89 B (-1.28%) 6.78 kB → 6.69 kB
src/components/autocomplete/CategoryAutocomplete.tsx 📉 -123 B (-1.48%) 8.1 kB → 7.98 kB
src/components/autocomplete/ItemHeader.tsx 📉 -37 B (-6.95%) 532 B → 495 B
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/index.js 2.56 MB → 2.56 MB (+220 B) +0.01%
static/js/wide.js 371.3 kB → 371.31 kB (+3 B) +0.00%

Smaller

Asset File Size % Changed
static/js/narrow.js 202.51 kB → 202.51 kB (-6 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/AppliedFilters.js 20.35 kB 0%
static/js/real-module.js 22.09 kB 0%
static/js/import.js 118.98 kB 0%
static/js/ReportRouter.js 1.18 MB 0%

Copy link
Contributor

github-actions bot commented Apr 10, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.2 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.2 MB 0%

@joel-jeremy joel-jeremy changed the title [WIP] Use desktop colors for mobile autocomplete modals Use desktop colors for mobile autocomplete modals Apr 10, 2024
@joel-jeremy joel-jeremy requested a review from shall0pass April 11, 2024 01:32
@shall0pass
Copy link
Contributor

It looks a lot better. In light mode, the close button must have a color that is the same as the background. Dark and midnight both show it clearly.

Screenshot_20240411-055856-938~2

@joel-jeremy
Copy link
Contributor Author

joel-jeremy commented Apr 11, 2024

@shall0pass should be fixed now :) However, I'd like to get this PR (#2491) merged first before merging this one to minimize merge work that I have to do. Can you take a look at that one too? :)

shall0pass
shall0pass previously approved these changes Apr 11, 2024
Copy link
Contributor

@shall0pass shall0pass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joel-jeremy
Copy link
Contributor Author

@shall0pass Thanks for checking the other PR! I have rebased this to fix merge conflicts :)

@joel-jeremy joel-jeremy merged commit 70e37c0 into master Apr 11, 2024
19 checks passed
@joel-jeremy joel-jeremy deleted the mobile-autocomplete-use-desktop-colors branch April 11, 2024 21:33
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Mobile autocomplete text colors
2 participants