Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maintenance] Pass HTTPS flag to dev container to enable HTTPS #2316

Merged

Conversation

jaarasys-henria
Copy link
Contributor

@jaarasys-henria jaarasys-henria commented Feb 2, 2024

Quality of Life enhancement. Stumbled upon this when running the Visual Regression Tests. Update the VRT docs to reflect dev container usage together with the HTTPS flag as well.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 44d2325
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/65bd594bb158190007e6a530
😎 Deploy Preview https://deploy-preview-2316.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 4.98 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/resize-observer.js 18.37 kB 0%
static/js/indexeddb-main-thread-worker-e59fee74.js 13.5 kB 0%
static/js/BackgroundImage.js 122.29 kB 0%
static/js/ButtonLink.js 379 B 0%
static/js/narrow.js 80.18 kB 0%
static/js/BalanceTooltip.js 6.06 kB 0%
static/js/AppliedFilters.js 28.99 kB 0%
static/js/wide.js 240.44 kB 0%
static/js/ReportRouter.js 1.84 MB 0%
static/js/index.js 2.64 MB 0%

Copy link
Contributor

github-actions bot commented Feb 2, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
1 1.18 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.18 MB 0%

@jaarasys-henria jaarasys-henria force-pushed the devcontainer_https branch 2 times, most recently from 7fb1e22 to 60697e5 Compare February 2, 2024 17:10
@jaarasys-henria jaarasys-henria changed the title [Enhancement] Pass HTTPS flag to dev container to enable HTTPS [Maintenance] Pass HTTPS flag to dev container to enable HTTPS Feb 2, 2024
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet! Thanks for your contribution!

@jaarasys-henria
Copy link
Contributor Author

Sweet! Thanks for your contribution!

No problem! I use Actual, I fix Actual. Wherever I know how :)

@MatissJanis MatissJanis merged commit 55f2d12 into actualbudget:master Feb 2, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Feb 2, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants