Skip to content

Commit

Permalink
[Maintenance] Pass HTTPS flag to dev container to enable HTTPS
Browse files Browse the repository at this point in the history
  • Loading branch information
jaarasys-henria committed Feb 2, 2024
1 parent 6ae2047 commit 44d2325
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 0 deletions.
2 changes: 2 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ services:
actual-development:
build: .
image: actual-development
environment:
- HTTPS
ports:
- '3001:3001'
volumes:
Expand Down
6 changes: 6 additions & 0 deletions packages/desktop-client/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@ First start a dev instance:
```sh
HTTPS=true yarn start
```

or using the dev container:
```
HTTPS=true docker compose up --build
```

Note the network IP address and port the dev instance is listening on.

Next, navigate to the root of your project folder, run the standartised docker container, and launch the visual regression tests from within it.
Expand Down
6 changes: 6 additions & 0 deletions upcoming-release-notes/2316.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [jaarasys-henria]
---

Enable passing HTTPS env variable flag to dev container for easy HTTPS enabling.

0 comments on commit 44d2325

Please sign in to comment.