-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔧 (ci) fork the electron build job - master and PR #2209
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to merge to fix PR CI
Alternatively we could probably change the env variable name, then re-set the one that is needed in package-electron
. But I'm guessing that would take some cross-env
work here as well.
Agreed. I think easier (short term) to just duplicate the job definition to unblock the PRs. |
Electron builds in PRs are now failing. Apparently even if an empty
CSC_LINK
env variable is set - it kicks off code signing. Which will obviously not work.. and should not work in PRs coming from forks.So I'm splitting the electron build job in 2x: one that runs on master (and code signs & notarizes the build) and one that runs on PRs (no code signing).
electron-userland/electron-builder#6921