Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 (ci) fork the electron build job - master and PR #2209

Merged
merged 3 commits into from
Jan 9, 2024

Conversation

MatissJanis
Copy link
Member

Electron builds in PRs are now failing. Apparently even if an empty CSC_LINK env variable is set - it kicks off code signing. Which will obviously not work.. and should not work in PRs coming from forks.

So I'm splitting the electron build job in 2x: one that runs on master (and code signs & notarizes the build) and one that runs on PRs (no code signing).

electron-userland/electron-builder#6921

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit b9375d7
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/659da189037214000898f65a
😎 Deploy Preview https://deploy-preview-2209.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@MatissJanis MatissJanis marked this pull request as ready for review January 9, 2024 19:43
Copy link
Contributor

github-actions bot commented Jan 9, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 3.08 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.43 MB 0%
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/wide-components.chunk.js 112.37 kB 0%
static/js/reports.chunk.js 77.81 kB 0%
static/js/narrow-components.chunk.js 42.42 kB 0%
static/js/553.chunk.js 13.14 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 1.92 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.24 MB 0%
xfo.xfo.kcab.worker.js 1014.45 kB 0%

@twk3 twk3 self-requested a review January 9, 2024 20:02
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to merge to fix PR CI

Alternatively we could probably change the env variable name, then re-set the one that is needed in package-electron. But I'm guessing that would take some cross-env work here as well.

@MatissJanis
Copy link
Member Author

Agreed. I think easier (short term) to just duplicate the job definition to unblock the PRs.

@MatissJanis MatissJanis merged commit ef9a7cf into master Jan 9, 2024
19 checks passed
@MatissJanis MatissJanis deleted the matiss/electron-certs branch January 9, 2024 20:06
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 9, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants