Skip to content

Commit

Permalink
🔧 (ci) fork the electron build job - master and PR (actualbudget#2209)
Browse files Browse the repository at this point in the history
  • Loading branch information
MatissJanis authored Jan 9, 2024
1 parent 9e69348 commit 9fc2486
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,10 @@ on:
push:
branches:
- master
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.ref != 'refs/heads/master' }}
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: false

jobs:
build:
Expand Down
43 changes: 43 additions & 0 deletions .github/workflows/electron-pr.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
name: Electron

defaults:
run:
shell: bash

env:
CI: true

on:
pull_request:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number }}
cancel-in-progress: true

jobs:
build:
strategy:
matrix:
os:
- ubuntu-latest
- windows-latest
- macos-latest
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v3
- if: ${{ startsWith(matrix.os, 'windows') }}
run: pip.exe install setuptools
- if: ${{ ! startsWith(matrix.os, 'windows') }}
run: python3 -m pip install setuptools
- name: Set up environment
uses: ./.github/actions/setup
- name: Build Electron
run: ./bin/package-electron
- name: Upload Build
uses: actions/upload-artifact@v3
with:
name: actual-electron-${{ matrix.os }}
path: |
packages/desktop-electron/dist/*.dmg
packages/desktop-electron/dist/*.exe
packages/desktop-electron/dist/*.AppImage
6 changes: 6 additions & 0 deletions upcoming-release-notes/2209.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
---
category: Maintenance
authors: [MatissJanis]
---

electron: split the build script in 2x parts to fix it failing when no code signing cert is provided (PRs from forks).

0 comments on commit 9fc2486

Please sign in to comment.