-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "error" Page for special accounts in Mobile #2114
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @HansiWursti !
This looks like a good improvement, to prevent crashes if someone re-orients their mobile after being on one of these pages.
The desired followup would be #757 to actually implement these pages. But preventing crashes is a good first step.
@HansiWursti can you open a new PR with this change. I merged it too early without confirming it worked with the other changes in master, and we had to revert it. |
* Add "error" Page for special accounts in Mobile
…t#2186) * Revert "Add "error" Page for special accounts in Mobile (actualbudget#2114)" This reverts commit b646234.
Hello,
if you access the mobile view from a "special" account url the website crashes:
/accounts/budgeted
/accounts/offbudget
/accounts/uncategorized
To recreate resize your browser while accessing one of the mentioned urls.
The Problem in my opinion is that these accounts not really exist and so account is later undefined and not able to be queried for the balance etc.
My simple fix is a little "error" page with a button back to the Accounts Overview:
Thank you