Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "error" Page for special accounts in Mobile #2114

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

HansiWursti
Copy link
Contributor

@HansiWursti HansiWursti commented Dec 22, 2023

Hello,

if you access the mobile view from a "special" account url the website crashes:

/accounts/budgeted
/accounts/offbudget
/accounts/uncategorized

To recreate resize your browser while accessing one of the mentioned urls.

The Problem in my opinion is that these accounts not really exist and so account is later undefined and not able to be queried for the balance etc.

My simple fix is a little "error" page with a button back to the Accounts Overview:

Bildschirmfoto am 2023-12-22 um 20 00 38

Thank you

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit b1e89b8
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/6585dbb05c31bf00080419fd
😎 Deploy Preview https://deploy-preview-2114.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Dec 22, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 3.09 MB → 3.09 MB (+366 B) +0.01%
Changeset
File Δ Size
src/components/accounts/MobileAccount.jsx 📈 +1.02 kB (+15.03%) 6.79 kB → 7.81 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/narrow-components.chunk.js 51.17 kB → 51.52 kB (+366 B) +0.70%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.26 MB 0%
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/wide-components.chunk.js 114.99 kB 0%
static/js/reports.chunk.js 77.3 kB 0%
static/js/553.chunk.js 28.94 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Dec 22, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.24 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@twk3 twk3 self-requested a review January 2, 2024 19:47
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @HansiWursti !

This looks like a good improvement, to prevent crashes if someone re-orients their mobile after being on one of these pages.

The desired followup would be #757 to actually implement these pages. But preventing crashes is a good first step.

@twk3 twk3 merged commit b646234 into actualbudget:master Jan 6, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 6, 2024
twk3 added a commit that referenced this pull request Jan 6, 2024
@twk3
Copy link
Contributor

twk3 commented Jan 6, 2024

@HansiWursti can you open a new PR with this change. I merged it too early without confirming it worked with the other changes in master, and we had to revert it.

twk3 added a commit that referenced this pull request Jan 6, 2024
* Revert "Add "error" Page for special accounts in Mobile (#2114)"

This reverts commit b646234.
HansiWursti added a commit to HansiWursti/actual that referenced this pull request Jan 9, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* Add "error" Page for special accounts in Mobile
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
…t#2186)

* Revert "Add "error" Page for special accounts in Mobile (actualbudget#2114)"

This reverts commit b646234.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants