Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReAdd Mobile Account Error Page #2204

Merged
merged 5 commits into from
Jan 9, 2024

Conversation

HansiWursti
Copy link
Contributor

Re implemented the mobile Account Error Page introduced in #2114 and reverted in #2186

Copy link

netlify bot commented Jan 9, 2024

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit e21915b
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/659d7ef94280a600080cd8e0
😎 Deploy Preview https://deploy-preview-2204.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
15 3.08 MB → 3.08 MB (-962 B) -0.03%
Changeset
File Δ Size
src/components/accounts/MobileAccount.jsx 📈 +811 B (+11.26%) 7.04 kB → 7.83 kB
../loot-core/src/client/queries.ts 📉 -643 B (-8.79%) 7.14 kB → 6.52 kB
src/components/accounts/MobileAccountDetails.jsx 📉 -3.89 kB (-43.27%) 8.99 kB → 5.1 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
static/js/narrow-components.chunk.js 43.34 kB → 42.78 kB (-569 B) -1.28%
static/js/main.js 1.43 MB → 1.43 MB (-393 B) -0.03%

Unchanged

Asset File Size % Changed
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/231.chunk.js 117.38 kB 0%
static/js/wide-components.chunk.js 112.37 kB 0%
static/js/reports.chunk.js 77.81 kB 0%
static/js/553.chunk.js 13.14 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 1.92 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Jan 9, 2024

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.23 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.24 MB 0%
xfo.xfo.kcab.worker.js 1014.45 kB 0%

@HansiWursti
Copy link
Contributor Author

Hi @twk3

the little change should now be compatible with master

Thank you!

@twk3 twk3 self-requested a review January 9, 2024 23:05
Copy link
Contributor

@twk3 twk3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @HansiWursti !

@twk3 twk3 merged commit e792afb into actualbudget:master Jan 9, 2024
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Jan 9, 2024
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* Add "error" Page for special accounts in Mobile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants