Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create category rules for ynab imports #1944

Merged
merged 4 commits into from
Nov 23, 2023

Conversation

twk3
Copy link
Contributor

@twk3 twk3 commented Nov 20, 2023

  • Enable learnCategories support in ynab transaction importing
  • Exposes learnCategories up through the api
  • Adds runTransfer conditions to batchUpdateTransactions so importer can still skip transfer processing

Part of #1943

@trafico-bot trafico-bot bot added the 🚧 WIP label Nov 20, 2023
Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit eab40ba
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/655e91d9d5c27700086cf8ac
😎 Deploy Preview https://deploy-preview-1944.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

github-actions bot commented Nov 20, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.97 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.16 MB 0%
static/js/665.chunk.js 824.28 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/444.chunk.js 156.11 kB 0%
static/js/wide-components.chunk.js 119.72 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/reports.chunk.js 74.42 kB 0%
static/js/narrow-components.chunk.js 52.71 kB 0%
static/js/301.chunk.js 13.31 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 911 B 0%

Copy link
Contributor

github-actions bot commented Nov 20, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB → 2.22 MB (+406 B) +0.02%
Changeset
File Δ Size
packages/api/methods.js 📈 +401 B (+3.26%) 12.03 kB → 12.42 kB
packages/loot-core/src/server/accounts/transactions.ts 📈 +151 B (+2.83%) 5.21 kB → 5.36 kB
packages/loot-core/src/server/importers/ynab5.ts 📈 +47 B (+0.46%) 9.88 kB → 9.92 kB
packages/loot-core/src/server/importers/ynab4.ts 📈 +47 B (+0.38%) 12.19 kB → 12.23 kB
packages/loot-core/src/server/api.ts 📈 +65 B (+0.38%) 16.91 kB → 16.97 kB
packages/loot-core/src/server/accounts/sync.ts 📈 +99 B (+0.32%) 29.88 kB → 29.98 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
kcab.worker.js 1.23 MB → 1.23 MB (+406 B) +0.03%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@twk3 twk3 force-pushed the ynab5-learn-categories branch from 053b1bc to e5a8247 Compare November 20, 2023 23:20
@twk3 twk3 changed the title [WIP] Create category rules for ynab5 imports [WIP] Create category rules for ynab imports Nov 21, 2023
@twk3 twk3 changed the title [WIP] Create category rules for ynab imports Create category rules for ynab imports Nov 21, 2023
@MatissJanis
Copy link
Member

👋 How can I test this change? Would you have an example import file I could use? And if so: what should I pay attention to?

@twk3
Copy link
Contributor Author

twk3 commented Nov 22, 2023

👋 How can I test this change? Would you have an example import file I could use? And if so: what should I pay attention to?

@MatissJanis the ynab4 test file in the e2e tests will work as an example for ynab4. With this change, after import there will be 3 rules created. One for tithing expense, and two for income.

I imported the that same file into ynab-web and then exported to get a similar data file but for ynab5/web here it is:
test-migrated-budget.json

That one should have the same result.

MatissJanis
MatissJanis previously approved these changes Nov 22, 2023
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM! Thanks for this improvement!

(let me know what you think about the small nitpicks)

packages/api/methods.js Outdated Show resolved Hide resolved
packages/loot-core/src/server/accounts/sync.ts Outdated Show resolved Hide resolved
packages/loot-core/src/server/api.ts Outdated Show resolved Hide resolved
@twk3 twk3 force-pushed the ynab5-learn-categories branch from 70256b8 to eab40ba Compare November 22, 2023 23:42
@twk3
Copy link
Contributor Author

twk3 commented Nov 22, 2023

(let me know what you think about the small nitpicks)

@MatissJanis Thanks, I've applied your suggestions!

@twk3 twk3 requested a review from MatissJanis November 22, 2023 23:55
Copy link
Member

@MatissJanis MatissJanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MatissJanis MatissJanis merged commit b4fd6e8 into actualbudget:master Nov 23, 2023
19 checks passed
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Nov 23, 2023
twk3 added a commit to twk3/actual-docs that referenced this pull request Nov 23, 2023
MatissJanis pushed a commit to actualbudget/docs that referenced this pull request Nov 26, 2023
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants