-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create category rules for ynab imports #1944
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
053b1bc
to
e5a8247
Compare
👋 How can I test this change? Would you have an example import file I could use? And if so: what should I pay attention to? |
@MatissJanis the ynab4 test file in the e2e tests will work as an example for ynab4. With this change, after import there will be 3 rules created. One for tithing expense, and two for income. I imported the that same file into ynab-web and then exported to get a similar data file but for ynab5/web here it is: That one should have the same result. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM! Thanks for this improvement!
(let me know what you think about the small nitpicks)
Co-authored-by: Matiss Janis Aboltins <[email protected]>
70256b8
to
eab40ba
Compare
@MatissJanis Thanks, I've applied your suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
To match changes from actualbudget/actual#1944
To match changes from actualbudget/actual#1944
Part of #1943