Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Turn on category learning for ynab importers #1943

Closed
2 tasks done
twk3 opened this issue Nov 20, 2023 · 2 comments
Closed
2 tasks done

[Feature] Turn on category learning for ynab importers #1943

twk3 opened this issue Nov 20, 2023 · 2 comments
Labels
feature This issue is a feature request

Comments

@twk3
Copy link
Contributor

twk3 commented Nov 20, 2023

Verified feature request does not already exist?

  • I have searched and found no existing issue

💻

  • Would you like to implement this feature?

Pitch: what problem are you trying to solve?

When importing from ynab4 or ynab web, there are no category rules created after import. Typically rules are only created when categories are manually set by the user. (Or brought in from an acutal import).

I think having them for the ynab importers would be an improvement, as the outcome would likely more closely match the ynab experience they were having with auto-categorisation.

Describe your ideal solution to this problem

  1. Expose the already existing learnCategories up through addTransaction and the api so importers can make use of it
  2. Turn on learnCategories for the importers

Teaching and learning

API changes should be documented in the API reference, but I don't think there is existing references that have boolean flags like this that have default values.

@twk3 twk3 added the feature This issue is a feature request label Nov 20, 2023
@github-actions github-actions bot added the needs votes Please upvote this feature request if you would like to see it implemented! label Nov 20, 2023
Copy link
Contributor

✨ Thanks for sharing your idea! ✨

This repository uses lodash style issue management for enhancements. That means enhancement issues are automatically closed. This doesn’t mean we don’t accept feature requests, though! We will consider implementing ones that receive many upvotes, and we welcome contributions for any feature requests marked as needing votes (just post a comment first so we can help you make a successful contribution).

The enhancement backlog can be found here: https://github.com/actualbudget/actual/issues?q=label%3A%22needs+votes%22+sort%3Areactions-%2B1-desc+

Don’t forget to upvote the top comment with 👍!

@twk3
Copy link
Contributor Author

twk3 commented Nov 23, 2023

This was completed in #1944

@youngcw youngcw removed the needs votes Please upvote this feature request if you would like to see it implemented! label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue is a feature request
Projects
None yet
Development

No branches or pull requests

2 participants