Fix Electron Build

[Shazib]

Some of the theme switching stuff has broken electron, at least on Windows builds.

This resolves that issue.

Dark mode still works in the netlify preview, and I haven't changed anything at all front-end wise, so I'm not sure why the visual regression tests have failed.

[netlify]

✅ Deploy Preview for actualbudget ready!

Name	Link
🔨 Latest commit	f9fb564
🔍 Latest deploy log	https://app.netlify.com/sites/actualbudget/deploys/655a6d33bf2c4800082c8625
😎 Deploy Preview	https://deploy-preview-1926.demo.actualbudget.org/
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
16	2.97 MB → 2.97 MB (-5 B)	-0.00%

Changeset

File	Δ	Size
src/browser-preload.browser.js	📈 +97 B (+2.10%)	4.52 kB → 4.61 kB
src/global-events.js	📉 -111 B (-2.10%)	5.15 kB → 5.05 kB

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

Asset	File Size	% Changed
static/js/main.js	1.16 MB → 1.16 MB (-5 B)	-0.00%

Unchanged

Asset	File Size	% Changed
static/js/665.chunk.js	824.28 kB	0%
static/media/Inter-italic.var.woff2	239.29 kB	0%
static/media/Inter-roman.var.woff2	221.86 kB	0%
static/js/444.chunk.js	156.11 kB	0%
static/js/231.chunk.js	117.37 kB	0%
static/js/wide-components.chunk.js	117.06 kB	0%
static/js/reports.chunk.js	74.37 kB	0%
static/js/narrow-components.chunk.js	52.67 kB	0%
static/js/301.chunk.js	13.31 kB	0%
static/js/473.chunk.js	13 kB	0%
static/js/resize-observer-polyfill.chunk.js	8.88 kB	0%
static/css/main.css	7.41 kB	0%
asset-manifest.json	2.07 kB	0%
index.html	1.66 kB	0%
static/media/browser-server.js	903 B	0%

[github-actions]

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count	Total bundle size	% Changed
2	2.22 MB	0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset	File Size	% Changed
kcab.worker.js	1.23 MB	0%
xfo.xfo.kcab.worker.js	1014.46 kB	0%

[MatissJanis]

Try updating your changes with latest master. That might fix the VRT job.

[MatissJanis]

Looks like it didn't help. There must be some sort of change that affects them from this PR.

[MikesGlitch]

If you look at the test: "budget-Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-chromium"

You can see it expects dark theme but gets light theme. Maybe if you fix that issue the others will be fixed?

the theme switch happens in playwright.config.js. It's to do with the window.Actual.setTheme("dark") not working anymore

[Shazib]

If you look at the test: "budget-Budget-renders-the-summary-information-available-funds-overspent-budgeted-and-for-next-month-chromium"

You can see it expects dark theme but gets light theme. Maybe if you fix that issue the others will be fixed?

the theme switch happens in playwright.config.js. It's to do with the window.Actual.setTheme("dark") not working anymore

Thanks for the info, i'll dig into it a bit.

The loading of the theme seems to happen fine in the netlify preview, i've compared it to other older PR's and it seems to be in a similar time.

Do you know if the tests run against the netlify instance?

[MikesGlitch]

") not working anymore

Thanks for the info, i'll dig into it a bit.

If you click the demo link and run this in the console

window.Actual.setTheme("dark") 

It should toggle it to dark. Or "light" will put it to light. That's broken the web demo - I'm assuming cause you removed it from the globals file.

I think the initialisation might be fine, but the VRT tests toggle it from light to dark with that setTheme call to check against the screenshots.

[Shazib]

It should toggle it to dark. Or "light" will put it to light. That's broken the web demo - I'm assuming cause you removed it from the globals file.

I think the initialisation might be fine, but the VRT tests toggle it from light to dark with that setTheme call to check against the screenshots.

Interesting, thanks! That gives me a thread to follow. I was going off the fact that the toggle button in the corner still works in the web version.
I didn't remove setTheme entirely though, i just moved it to the preload file.

Anyway digging into it now, thanks for the guidance!

[Shazib]

@MikesGlitch Thanks, Fixed!

[MatissJanis]

Thanks @Shazib ! <3

[MatissJanis]

And also thanks @MikesGlitch for the assist!