Fix Electron Build (#1926)

actualbudget · Nov 20, 2023 · e6e184c · e6e184c
1 parent 9c6d9ec
commit e6e184c
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 6 deletions.
diff --git a/packages/desktop-client/src/browser-preload.browser.js b/packages/desktop-client/src/browser-preload.browser.js
@@ -129,7 +129,9 @@ global.Actual = {
     return worker;
   },
 
-  setTheme: () => {},
+  setTheme: theme => {
+    window.__actionsForMenu.saveGlobalPrefs({ theme: theme });
+  },
 };
 
 document.addEventListener('keydown', e => {

diff --git a/packages/desktop-client/src/global-events.js b/packages/desktop-client/src/global-events.js
@@ -14,10 +14,6 @@ export function handleGlobalEvents(actions, store) {
     // to update.
   });
 
-  global.Actual.setTheme = theme => {
-    actions.saveGlobalPrefs({ theme });
-  };
-
   listen('server-error', info => {
     actions.addGenericErrorNotification();
   });

diff --git a/packages/desktop-electron/index.js b/packages/desktop-electron/index.js
@@ -407,3 +407,11 @@ ipcMain.on('apply-update', () => {
 ipcMain.on('update-menu', (event, isBudgetOpen) => {
   updateMenu(isBudgetOpen);
 });
+
+ipcMain.on('set-theme', theme => {
+  let obj = { theme: theme };
+
+  clientWin.webContents.executeJavaScript(
+    `window.__actionsForMenu && window.__actionsForMenu.saveGlobalPrefs(${obj})`,
+  );
+});
diff --git a/packages/desktop-electron/preload.js b/packages/desktop-electron/preload.js
@@ -55,5 +55,7 @@ contextBridge.exposeInMainWorld('Actual', {
     return socketPromise;
   },
 
-  setTheme: () => {},
+  setTheme: theme => {
+    ipcRenderer.send('set-theme', theme);
+  },
 });
diff --git a/upcoming-release-notes/1926.md b/upcoming-release-notes/1926.md
@@ -0,0 +1,6 @@
+---
+category: Bugfix
+authors: [Shazib]
+---
+
+Fix issue with electron builds being stuck on a blank screen.