-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ (mobile) pull down to trigger bank-sync #1663
Conversation
✅ Deploy Preview for actualbudget ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
</SchedulesProvider> | ||
)} | ||
</SyncRefresh> | ||
<SchedulesProvider |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bundle Stats — desktop-clientHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
Bundle Stats — loot-coreHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
@@ -934,7 +934,6 @@ class Transaction extends PureComponent { | |||
backgroundColor: 'white', | |||
border: 'none', | |||
width: '100%', | |||
'&:active': { opacity: 0.1 }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was kinda annoying on mobile devices.. when you hold the transaction - it change its style. When you release - it opens the transaction (as expected). It would be nicer to not have this weird in-between style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Only concern is that the last update on that library was last year but other than that, looks very cool! :)
Agreed. Pull to refresh saves us some precious screen real estate in small screens and feels native, too. |
* ✨ (mobile) pull down to trigger bank-sync * Release notes * Remove canSync checks
Feature: pull down on the accounts (plural) or transaction list to trigger a sync (simple actual-server sync + bank-sync (if set-up)) while using the mobile app.