Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (mobile) pull down to trigger bank-sync #1663

Merged
merged 3 commits into from
Sep 7, 2023

Conversation

MatissJanis
Copy link
Member

@MatissJanis MatissJanis commented Sep 6, 2023

Feature: pull down on the accounts (plural) or transaction list to trigger a sync (simple actual-server sync + bank-sync (if set-up)) while using the mobile app.

@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 35b9bf2
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64f8b58a4baf5b00085da530
😎 Deploy Preview https://deploy-preview-1663.demo.actualbudget.org/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

</SchedulesProvider>
)}
</SyncRefresh>
<SchedulesProvider
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommended when reviewing:
Screenshot 2023-09-06 at 18 14 27

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.46 MB → 2.46 MB (+6.61 kB) +0.26%
Changeset
File Δ Size
../../node_modules/react-simple-pull-to-refresh/build/index.esm.js 🆕 +13.84 kB 0 B → 13.84 kB
src/components/accounts/MobileAccountDetails.js 📈 +345 B (+4.62%) 7.29 kB → 7.63 kB
package.json 📈 +40 B (+1.87%) 2.09 kB → 2.13 kB
src/components/transactions/MobileTransaction.js 📉 -82 B (-0.16%) 48.66 kB → 48.58 kB
src/components/accounts/MobileAccounts.js 📉 -92 B (-0.97%) 9.3 kB → 9.21 kB
src/components/budget/MobileBudgetTable.js 📉 -2.1 kB (-5.53%) 37.96 kB → 35.86 kB
src/components/accounts/MobileAccount.js 📉 -796 B (-10.34%) 7.52 kB → 6.74 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
static/js/narrow-components.chunk.js 25.84 kB → 32.47 kB (+6.63 kB) +25.66%

Smaller

Asset File Size % Changed
static/js/main.js 1.11 MB → 1.11 MB (-24 B) -0.00%

Unchanged

Asset File Size % Changed
static/js/678.chunk.js 420.74 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/713.chunk.js 156.56 kB 0%
static/js/wide-components.chunk.js 125.44 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/reports.chunk.js 28.65 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/389.chunk.js 12.76 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@@ -934,7 +934,6 @@ class Transaction extends PureComponent {
backgroundColor: 'white',
border: 'none',
width: '100%',
'&:active': { opacity: 0.1 },
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was kinda annoying on mobile devices.. when you hold the transaction - it change its style. When you release - it opens the transaction (as expected). It would be nicer to not have this weird in-between style.

Copy link
Contributor

@joel-jeremy joel-jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Only concern is that the last update on that library was last year but other than that, looks very cool! :)

@MatissJanis MatissJanis merged commit 0e539d9 into master Sep 7, 2023
@MatissJanis MatissJanis deleted the matiss/mobile-bank-sync branch September 7, 2023 05:56
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved labels Sep 7, 2023
@trevdor
Copy link
Contributor

trevdor commented Sep 7, 2023

Agreed. Pull to refresh saves us some precious screen real estate in small screens and feels native, too.

@shall0pass shall0pass mentioned this pull request Sep 8, 2023
8 tasks
FlorianLang06 pushed a commit to FlorianLang06/actual that referenced this pull request Mar 7, 2024
* ✨ (mobile) pull down to trigger bank-sync

* Release notes

* Remove canSync checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Merged Pull Request has been merged successfully
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants