Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Refresh button for linked accounts #1664

Closed
wants to merge 3 commits into from

Conversation

benjylxwang
Copy link

Added a refresh button in the mobile view for running the sync (to gocardless) and download function

@netlify
Copy link

netlify bot commented Sep 6, 2023

Deploy Preview for actualbudget ready!

Name Link
🔨 Latest commit 2c09db1
🔍 Latest deploy log https://app.netlify.com/sites/actualbudget/deploys/64f8c1bb34f7360008e48022
😎 Deploy Preview https://deploy-preview-1664.demo.actualbudget.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Bundle Stats — desktop-client

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
16 2.46 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
static/js/main.js 1.11 MB 0%
static/js/678.chunk.js 420.74 kB 0%
static/media/Inter-italic.var.woff2 239.29 kB 0%
static/media/Inter-roman.var.woff2 221.86 kB 0%
static/js/713.chunk.js 156.56 kB 0%
static/js/wide-components.chunk.js 125.44 kB 0%
static/js/231.chunk.js 117.37 kB 0%
static/js/reports.chunk.js 28.65 kB 0%
static/js/narrow-components.chunk.js 25.7 kB 0%
static/js/473.chunk.js 13 kB 0%
static/js/389.chunk.js 12.76 kB 0%
static/js/resize-observer-polyfill.chunk.js 8.88 kB 0%
static/css/main.css 7.41 kB 0%
asset-manifest.json 2.07 kB 0%
index.html 1.66 kB 0%
static/media/browser-server.js 903 B 0%

@github-actions
Copy link
Contributor

github-actions bot commented Sep 6, 2023

Bundle Stats — loot-core

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
2 2.22 MB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
kcab.worker.js 1.23 MB 0%
xfo.xfo.kcab.worker.js 1014.46 kB 0%

@benjylxwang
Copy link
Author

Oh I just saw #1663 which does a very similar thing and clashes horribly with this :D
Is there any appetite for having the button as well? I can fix the merge after #1663 goes in and put this up again

@benjylxwang benjylxwang marked this pull request as ready for review September 6, 2023 18:18
@MatissJanis
Copy link
Member

👋 Thanks for the contribution! Very exciting to see new folks contribute to Actual!

I think given we just added pull-down-to refresh functionality for this (in #1663), then the button would not be necessary anymore.

What do you think @trevdor ?

@trevdor
Copy link
Contributor

trevdor commented Sep 11, 2023

Agreed—we definitely need the functionality, @benjylxwang, and appreciate you working on it. But I don’t see a need for a button now that pull-to-refresh handles import refresh.

Have we missed anything about your goal for this PR?

@benjylxwang
Copy link
Author

Nope was just adding the button. I'll close it in that case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants