Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOISSUE - Add Read Property and WHOIS support #1
base: main
Are you sure you want to change the base?
NOISSUE - Add Read Property and WHOIS support #1
Changes from 23 commits
67f2ced
354108b
c46d913
2e6bbc4
6c17e28
498161a
fc6b475
1155568
b610764
12b76cc
732dc10
292c949
f231ed7
76792fa
6b2822e
0c7837d
42fcc50
b8a8db0
079d92b
3eb993e
d2c5be9
e93285d
b64c033
c9cc370
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package name seems odd.
bacnet/pkg/bacnet
. Why not move bacnet to the root of the project as this repository is bacnet package