NOISSUE - Add Read Property and WHOIS support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
drasko
requested changes
Aug 30, 2023
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
add bvlc update npdu add transport Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
The BACnetValue.Decode() method now returns an error to handle decoding errors properly. - The method signature has been updated to return (int, error) - If there is an error during decoding, the method now returns (-1, err) This change ensures that decoding errors are properly handled and allows for better error reporting and debugging. Signed-off-by: SammyOina <[email protected]>
…eadPropertyACK.Decode() method The decoding error for object_identifier and property_identifier in the ReadPropertyACK.Decode() method has been fixed. This change ensures that the error message accurately reflects the cause of the decoding failure. This commit addresses the following changes: - Updated error message for object_identifier decoding error - Updated error message for property_identifier decoding error Signed-off-by: SammyOina <[email protected]>
The BACnetValue.Decode() method was updated to handle decoding errors in the ReadAccessSpecification and BACnetDeviceObjectPropertyReference types. This ensures that the decoding process is accurate and reliable. Signed-off-by: SammyOina <[email protected]>
Signed-off-by: SammyOina <[email protected]>
SammyOina
changed the title
…oding The commit fixes the issue where unnecessary print statements were present in the code. Additionally, it adds the decoding of the BACnet message in the response of the read property example. Signed-off-by: SammyOina <[email protected]>
rodneyosodo
requested changes
Sep 19, 2023
Remove commented out code and fix formatting in readProperty.go file. extract constants add coomments Signed-off-by: SammyOina <[email protected]>
The import and function name in readProperty.go have been fixed to use the correct package and function names. - Changed import from "bacnet" to "example/bacnet" - Changed function name from "NewBACnetAddress" to "NewAddress" - Changed "bacnet.BacnetMaxSegments" to "bacnet.MaxSegments" Signed-off-by: SammyOina <[email protected]>
- Fix address creation in readProperty.go and whois.go to pass the correct parameters to the bacnet.NewAddress function. - In readProperty.go, change `bacnet.NewAddress(0, nil, "127.0.0.6:47809", &netType)` to `bacnet.NewAddress(0, nil, "127.0.0.6:47809", &netType)`. - In whois.go, change `*bacnet.NewAddress(0xFFFF, nil, "127.0.0.255:47809", &netType)` to `bacnet.NewAddress(0xFFFF, nil, "127.0.0.255:47809", &netType)`. This commit fixes the address creation in the readProperty and whois.go files by passing the correct parameters to the bacnet.NewAddress function. Signed-off-by: SammyOina <[email protected]>
drasko
requested changes
Sep 21, 2023
Signed-off-by: SammyOina <[email protected]>
rodneyosodo
requested changes
Oct 3, 2023
| "net" | ||
| "time" | ||
|
|
||
| "github.com/absmach/bacnet/pkg/bacnet" |
There was a problem hiding this comment.
The package name seems odd. bacnet/pkg/bacnet. Why not move bacnet to the root of the project as this repository is bacnet package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
bacnetpackage. This includes encoding and decoding of various BACnet messages such as WhoIs, IAm, YouAre, and ReadProperty.BitArraytype in theinternalpackage to handle bit-level operations.encodingpackage for handling encoding and decoding of various data types in the BACnet protocol.transportpackage with support for UDP transport, including functionality to determine the broadcast address.bacnetpackage that supports ReadProperty and WHoIs operations.Which issue(s) does this PR fix/relate to?
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes
WhoIS is still buggy.
To test the package you can simulate a bacnet server using an external library such as this https://github.com/Kretiss/BACnet-simulator/blob/main/rooms_simulator.py and run one of the examples in the example directory.