Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API 1.1 ongoing review PR #258

Closed
wants to merge 39 commits into from
Closed

API 1.1 ongoing review PR #258

wants to merge 39 commits into from

Conversation

mattheworiordan
Copy link
Member

We will use this PR to track ongoing proposed changes for the 1.1 specification. Commits merged in are generally accepted to be included in 1.1

@mattheworiordan mattheworiordan temporarily deployed to ably-docs-pr-258 January 20, 2017 17:17 Inactive
@SimonWoolf
Copy link
Member

Rebased on latest master (somewhat painfully) and merged in #306, #293, #186

@mattheworiordan mattheworiordan mentioned this pull request Nov 7, 2017
4 tasks
@mattheworiordan mattheworiordan force-pushed the master branch 3 times, most recently from cc0bb4b to 2d11e3e Compare November 18, 2017 22:36
@mattheworiordan
Copy link
Member Author

We need to remove the various unrelated commits

Wait, which commits do you want to remove from this PR? Commits that have already been merged into this pr are ones we've previously agreed should definitely go into 1.1, would be surprising to remove any now

See commits a49056e...79ffa18

Optional as in our customers can flip a switch to turn it on?

I believe Matt meant optional in the sense that client libraries do not have to implement it in order to be considered to conform to the 1.1 spec

Yes

@paddybyers
Copy link
Member

Make it clear exception reporting is an optional feature in client libs

#408

We need to remove the various unrelated commits

Done, in https://github.com/ably/docs/tree/integration-spec-1-1

We should add extras to PresenceMessage for consistency (it's one field, so now is a good time for that)

#409

Close #339

In progress

Decide if ably/specification#71 is still needed

I'm proposing to defer (ably/specification#71)

Confirm if #328 is done

Yes

Consider ably/specification#81 to ensure 1.1 is more stable moving forwards. All libs should do this now anyway so we're not adding complexity, just tightening up the requirements

#411

Close #242

Done

Consider #232 given it's a one liner in all libraries but can save lots of headaches for developers. If we follow a standard URL format for errors now we can save a lot of dev headaches, and it's easy to implement. I don't think we should wait for 1.2, that could be 6 months away or more,.

#412

I think ably/specification#75 is mostly addressed now?

#410

I think #75 is resolved with this work?

Yes

Support transient publishing #284, even if we mark this as optional. At least it will be in the spec and finalised. I think we can ignore attach flags as it should be unrelated and we just need a simple API for publishing over a realtime connection.

Done already

@mattheworiordan mattheworiordan temporarily deployed to ably-docs-pr-258 April 12, 2018 06:51 Inactive
@mattheworiordan mattheworiordan temporarily deployed to ably-docs-pr-258 April 13, 2018 08:02 Inactive
withakay and others added 2 commits April 26, 2018 11:39
@mattheworiordan mattheworiordan temporarily deployed to ably-docs-pr-258 April 26, 2018 12:13 Inactive
@mattheworiordan mattheworiordan temporarily deployed to ably-docs-pr-258 April 27, 2018 08:27 Inactive
@mattheworiordan mattheworiordan temporarily deployed to ably-docs-pr-258 May 9, 2018 10:02 Inactive
@mattheworiordan mattheworiordan temporarily deployed to ably-docs-pr-258 May 9, 2018 14:31 Inactive
@mattheworiordan mattheworiordan temporarily deployed to ably-docs-pr-258 May 15, 2018 08:07 Inactive
@mattheworiordan mattheworiordan temporarily deployed to ably-docs-pr-258 May 15, 2018 08:09 Inactive
@mattheworiordan mattheworiordan temporarily deployed to ably-docs-pr-258 May 18, 2018 08:32 Inactive
@SimonWoolf
Copy link
Member

I've now combined master-1-1 and integration-spec-1-1 and promoted the result to master. The previous master is now https://github.com/ably/docs/tree/v1.0-as-amended

@SimonWoolf SimonWoolf closed this Jun 19, 2018
@paddybyers paddybyers deleted the master-1-1 branch November 16, 2018 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants